Page MenuHomeFreeBSD

www/firefox, www/seamonkey: unbreak build with base libstdc++ on i386, powerpc
ClosedPublic

Authored by jbeich on Jan 20 2015, 9:44 PM.
Tags
None
Referenced Files
F153470525: D1569.id3272.diff
Tue, Apr 21, 8:41 AM
F153413372: D1569.id3272.diff
Tue, Apr 21, 12:52 AM
F153413286: D1569.id3272.diff
Tue, Apr 21, 12:52 AM
Unknown Object (File)
Mon, Apr 20, 1:54 PM
Unknown Object (File)
Thu, Apr 16, 1:23 PM
Unknown Object (File)
Tue, Apr 14, 9:00 AM
Unknown Object (File)
Sat, Apr 11, 11:36 PM
Unknown Object (File)
Wed, Apr 8, 12:00 PM
Subscribers

Details

Reviewers
flo
Summary

Unbreak build with base libstdc++ on i386 and powerpc

std::abs(int64_t) for 32bit archs or std::llabs are not available in
base libstdc++ or before 10.0-RELEASE (r255294) for libstdc++ in
lang/gcc47 and earlier (libstdc++/54686). To avoid the build error use
mozilla::Abs which implements overloads for all signed natural types
but has unsigned return value.

This change won't be requried for Firefox 36 et al.

PR: 196772
Reported by: many
Patch by: bar (initial version)
Obtained from: https://github.com/mozilla/gecko-dev/commit/e664fe8
Approved by: flo (mentor)
MFH: 2015Q1

Test Plan

A few |poudriere bulk| logs are attached to the bug. The rest is
assumed to work fine - too many combinations to test.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

jbeich retitled this revision from to www/firefox, www/seamonkey: unbreak build with base libstdc++ on i386, powerpc.
jbeich updated this object.
jbeich edited the test plan for this revision. (Show Details)
jbeich added a reviewer: flo.
jbeich added a subscriber: beat.
flo edited edge metadata.

Approved.

This revision is now accepted and ready to land.Jan 20 2015, 9:58 PM