- Add new port graphics/lazpaint
- Use FLAVORS (need portmgr approval)
- Depends of https://reviews.freebsd.org/D14661
Details
Details
- Reviewers
- None
- Commits
- rP476570: - New port: graphics/lazpaint
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| lazpaint/Makefile | ||
|---|---|---|
| 36 | Remove. There should be a wærning telling you not to do that. | |
Comment Actions
The whole Makefile is badly ordered. Please read Chapter 15. Order of Variables in Port Makefiles.
Comment Actions
Does not need portmgr approval, not adding FLAVORS.
| Makefile | ||
|---|---|---|
| 24 | Default, please remove. | |
| 35 | Like the warning told you, this is wrong, please remove the line. | |
| 37–40 | As you have no control on what the default flavor is, this should probably be better written as something like this: USE_FPC_gtk2= cairo
USE_GNOME_gtk2= cairo
USE_FPC+= ${USE_FPC_${FLAVOR}}
USE_GNOME+= ${USE_GNOME_${FLAVOR}} | |
| Makefile | ||
|---|---|---|
| 31–33 | Wrong place in the Makefile. They are flavors helpers. See Chapter 15. Order of Variables in Port Makefiles. | |