Page MenuHomeFreeBSD
Differential D15228

Flavorize x11-themes/adwaita-qt4 and x11-themes/adwaita-qt5 (via x11-themes/adwaita-common).
ClosedPublic
Actions

Authored by tcberner on Apr 29 2018, 7:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 8:53 PM
Unknown Object (File)
Oct 10 2024, 10:52 PM
Unknown Object (File)
Sep 27 2024, 8:37 PM
Unknown Object (File)
Sep 24 2024, 12:11 PM
Unknown Object (File)
Sep 24 2024, 7:32 AM
Unknown Object (File)
Sep 14 2024, 6:26 AM
Unknown Object (File)
Sep 13 2024, 6:35 PM
Unknown Object (File)
Sep 8 2024, 7:32 PM
View All 96 Files
Subscribers
None

Details

Reviewers
mat
Group Reviewers
portmgr
Commits
rP472790: x11-themes/adwaita-qt[45] move to a flavored version
Summary

Move the three ports into one

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tcberner created this revision.Apr 29 2018, 7:46 PM
Harbormaster completed remote builds in B16339: Diff 41975.Apr 29 2018, 7:46 PM
tcberner updated this revision to Diff 41976.Apr 29 2018, 7:54 PM

Drop now unnecessary GH_PROJECT, and siwtch GH_PROJECT to the proper one:

https://github.com/FedoraQt/adwaita-qt
Harbormaster completed remote builds in B16340: Diff 41976.Apr 29 2018, 7:54 PM
tcberner updated this revision to Diff 43888.Jun 16 2018, 11:20 AM

ping @mat :)

Harbormaster completed remote builds in B17337: Diff 43888.Jun 16 2018, 11:20 AM
mat added inline comments.Jun 18 2018, 9:52 AM
MOVED
10279–10281 ↗(On Diff #43888)

MOVED supports flavors, so you may want to add @qt4/@qt5 where appropriate.

x11-themes/adwaita-qt/Makefile
7 ↗(On Diff #43888)

We prefer that the helpers be used instead of defining PKGNAMESUFFIX in such a manner. Something like:

qt4_PKGNAMESUFFIX= 4
qt5_PKGNAMESUFFIX= 5

in the flavors block of the Makefile.

tcberner updated this revision to Diff 44023.Jun 18 2018, 7:04 PM
  • Fixup MOVED
  • set PKGNAMESUFFIX via the helper
Harbormaster completed remote builds in B17416: Diff 44023.Jun 18 2018, 7:04 PM
mat accepted this revision as: portmgr.Jun 18 2018, 9:49 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 19 2018, 2:07 PM
Closed by commit rP472790: x11-themes/adwaita-qt[45] move to a flavored version (authored by tcberner). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
3 lines
x11-themes/
4 lines
adwaita-common/
40 lines
3 lines
4 lines
adwaita-qt/
35 lines
3 lines
4 lines
adwaita-qt4/
10 lines
adwaita-qt5/
10 lines

Diff 44073

View Options

head/MOVED

Loading...
View Options

head/x11-themes/Makefile

Loading...
View Options

head/x11-themes/adwaita-common/Makefile

Loading...
View Options

head/x11-themes/adwaita-common/distinfo

Loading...
View Options

head/x11-themes/adwaita-common/pkg-descr

Loading...
View Options

head/x11-themes/adwaita-qt/Makefile

Loading...
View Options

head/x11-themes/adwaita-qt/distinfo

Loading...
View Options

head/x11-themes/adwaita-qt/pkg-descr

Loading...
View Options

head/x11-themes/adwaita-qt4/Makefile

Loading...
View Options

head/x11-themes/adwaita-qt5/Makefile

Loading...