I haven't finished with the markup conversion yet - I wanted to put this in as is so that I can compare the markup diffs in Phabricator. Another upload coming shortly.
Details
Details
Diff Detail
Diff Detail
- Repository
- rD FreeBSD doc repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
- remove copy of last quarter's clusteradm report that crept in
- exclude unrelated CVSup change
Comment Actions
Just a few nits inline; this mostly is in good shape.
| en_US.ISO8859-1/htdocs/news/status/report-2014-10-2014-12.xml | ||
|---|---|---|
| 2462 ↗ | (On Diff #3158) | Be sure to use tabs instead of 8 spaces. (I forget whether phabricator actually shows tabs distinctly from spaces.) |
| 2488 ↗ | (On Diff #3158) | I think one can hyphenate "first-year" as a compound adjective, though it's quite minor. |
| 2505 ↗ | (On Diff #3158) | I don't think a line break is needed here. |
| 2526 ↗ | (On Diff #3158) | The prevailing style in the document seems to be to close the </p> before starting a <ul> (and indent as appropriate), so I would prefer that here (and later in the file). |
| 2540 ↗ | (On Diff #3158) | I think there should be an "and" before "needs", since the list is "use of FreeBSD, plans, and needs", and the "help facilitate" is a separate thing. |
| 2552 ↗ | (On Diff #3158) | No need for a line break here. |
| 2593 ↗ | (On Diff #3158) | No need for a line break here, unless you want to split the <p> environment in twain. |
| en_US.ISO8859-1/htdocs/news/status/report-2014-10-2014-12.xml | ||
|---|---|---|
| 2462 ↗ | (On Diff #3158) | Confirmed, there are no instances of 8 spaces. |
| 2488 ↗ | (On Diff #3158) | ok |
| 2505 ↗ | (On Diff #3158) | I did it to stay under 70 cols to keep igor happy |
| 2526 ↗ | (On Diff #3158) | Afaict I followed the existing formatting, e.g. at line 300. I'll adjust if you can confirm how it should be, or otherwise I can commit and let you fix up as it should be. |
| 2540 ↗ | (On Diff #3158) | agreed |
| 2552 ↗ | (On Diff #3158) | ok |
Comment Actions
This is in commitable state, I think. Since we're on a deadline, you should probably go ahead and commit without a further round of review.
| en_US.ISO8859-1/htdocs/news/status/report-2014-10-2014-12.xml | ||
|---|---|---|
| 2505 ↗ | (On Diff #3158) | Er, I meant that "Dru Lavigne gave..." could be moved up a line. |
| 2526 ↗ | (On Diff #3158) | I think you should probably just commit, at this point. It's unclear that any fixup would really be needed, anyway. |