Page MenuHomeFreeBSD
Differential D15210

Import upstreaam code to fix nll pointer dereference
ClosedPublic
Actions

Authored by madpilot on Apr 26 2018, 4:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 12:15 PM
Unknown Object (File)
Tue, Nov 19, 6:56 PM
Unknown Object (File)
Tue, Nov 19, 9:15 AM
Unknown Object (File)
Thu, Nov 14, 1:24 PM
Unknown Object (File)
Wed, Nov 13, 3:13 PM
Unknown Object (File)
Wed, Nov 13, 2:55 PM
Unknown Object (File)
Mon, Nov 11, 6:51 AM
Unknown Object (File)
Thu, Nov 7, 7:17 PM
View All 97 Files
Subscribers
mat
tcberner

Details

Reviewers
tcberner
Group Reviewers
kde
Commits
rP468623: MFH: r468386
rP468386: Import upstream commit fixing a crash caused by a null pointer
Summary

While using calibre I was experiencing frequent crashes. Some investigation leaded me to this upstream commit:

https://github.com/annulen/webkit/commit/0e75f3272d149bc64899c161f150eb341a2417af

I am running with this patch applied and I don't see crashes anymore.

I'd like to apply it to the official port.

I think this should also be merged to the quarterly branch.

Test Plan

I'm using patched code locally without problems. It's also alreaady committed to the upstream repo.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

madpilot created this revision.Apr 26 2018, 4:09 PM
Herald added a subscriber: mat. · View Herald TranscriptApr 26 2018, 4:09 PM
Harbormaster completed remote builds in B16313: Diff 41887.Apr 26 2018, 4:09 PM
madpilot edited the summary of this revision. (Show Details)Apr 26 2018, 4:15 PM
tcberner accepted this revision.Apr 26 2018, 6:24 PM
tcberner added a subscriber: tcberner.

If it builds, go ahead.
But please add the URL to the commit to the top of the patch so we have the content.

This revision is now accepted and ready to land.Apr 26 2018, 6:24 PM
Closed by commit rP468386: Import upstream commit fixing a crash caused by a null pointer (authored by madpilot). · Explain WhyApr 26 2018, 9:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
www/
qt5-webkit/
2 lines
files/
18 lines

Diff 41909

View Options

head/www/qt5-webkit/Makefile

Loading...
View Options

head/www/qt5-webkit/files/patch-Source_WebKit_qt_WebCoreSupport_QWebPageAdapter.cpp

Loading...