Page MenuHomeFreeBSD

x11-toolkits/p5-Gtk2-Ex-Utils: Add LICENSE
ClosedPublic

Authored by bofh on Jan 13 2015, 11:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 7 2024, 8:15 AM
Unknown Object (File)
Dec 1 2024, 4:45 AM
Unknown Object (File)
Dec 1 2024, 4:45 AM
Unknown Object (File)
Dec 1 2024, 4:32 AM
Unknown Object (File)
Nov 29 2024, 12:48 AM
Unknown Object (File)
Sep 23 2024, 8:05 PM
Unknown Object (File)
Sep 23 2024, 2:00 PM
Unknown Object (File)
Sep 18 2024, 6:45 AM
Subscribers
None

Details

Reviewers
bapt
marino
Summary
  • Pass Maintainership [1]

Differential Revision: https://reviews.freebsd.org/DXXXX
Submitted by: pauls@utdallas.edu
Approved by: xxxx(mentor)

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bofh retitled this revision from to x11-toolkits/p5-Gtk2-Ex-Utils: Add LICENSE.
bofh updated this object.
bofh edited the test plan for this revision. (Show Details)
bofh added reviewers: bapt, marino.
bofh set the repository for this revision to rP FreeBSD ports repository.
marino edited edge metadata.

same comment, add (LGPL21) after LICENSE for a more useful commit message

This revision is now accepted and ready to land.Jan 13 2015, 11:53 AM

hmm, you committed without taking care of my comment again.
Maybe I should use the "request change" disposition? I've been approving these "contingent on this change" approach to save a round of back-and-forth, but the review is getting lost so maybe it's a bad idea on my part.

In D1512#8, @marino wrote:

hmm, you committed without taking care of my comment again.
Maybe I should use the "request change" disposition? I've been approving these "contingent on this change" approach to save a round of back-and-forth, but the review is getting lost so maybe it's a bad idea on my part.

My mistake. But I took care of the second one.

I've been using "approved" when the comments are on the level of a suggestion (e.g. the current version is okay, but it could be better). I always use "change requested" for a real problem.

I guess you are going off the email titles, that's where the info gets lost?

In D1512#10, @marino wrote:

I've been using "approved" when the comments are on the level of a suggestion (e.g. the current version is okay, but it could be better). I always use "change requested" for a real problem.

I guess you are going off the email titles, that's where the info gets lost?

Yes. I was. Now I am shifting towards Phabricator only. :)

or you could just open the email and see if there was a comment along with the approval. =)

In D1512#12, @marino wrote:

or you could just open the email and see if there was a comment along with the approval. =)

No. I will follow phabricator as I need to make the svn commit message from phabricator. Won't mixup mail and phabricator. :)