Details
- Reviewers
bapt wg - Group Reviewers
O5: Ports Framework (Owns No Changed Paths) portmgr
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| Mk/Uses/mate.mk | ||
|---|---|---|
| 135 | This won't work, LIB_DEPENDS needs a library. If the package does not install one anymore just remove the line. | |
| audio/libmatemixer/pkg-plist | ||
| 26 | Are these options gone? please check and either remove the options or add back the optional files back to the plist. | |
| graphics/atril/pkg-plist | ||
| 59 | These and others are options, please add back the %%FOO%% tags (and check if the plist still is correct when they are enabled) | |
| sysutils/mate-control-center/pkg-plist | ||
| 78 | I think this file is generated by a tool, you should not list them. | |
| x11-fm/caja/pkg-plist | ||
| 246 | Only list the xml files. The rest is autogenerated by the update-mime-database command I think it was. | |
| x11/mate-applets/Makefile | ||
| 54 | These can be removed, and the USES=shebangfix too, if there aren't more SHEBANG_FILES lines. | |
| x11/mate-applets/pkg-plist | ||
| 3 | Again optional plist entries. | |
Options are such a pain sometimes, I know.. When you change options in plist, it is good to run "make check-plist" after the change, with and without the options on (port rebuild). yes this is more work but it safe work later when someone stumbles across a broken plist entry. Also if you didn't know already, when you change the pkg-plist, you can run "make restage" to "regen" the stage dir and update the plist the framework builds. So you don't have to rebuild the whole port to check pkg-plist changes.
| graphics/atril/pkg-plist | ||
|---|---|---|
| 61 | Duplicate of the line above it? | |
| x11/mate-applets/Makefile | ||
| 28 | I guess these comments can be removed now? | |
| x11/mate-applets/pkg-plist | ||
| 21 | More %%BATTERY%% lines. | |