Page MenuHomeFreeBSD

Add Tom Jones (thj) as a new src committer.

Authored by thj on Apr 11 2018, 3:05 PM.



Add Tom Jones (thj) as a new src committer.

  • Add authors.ent entity
  • Add email
  • Add news item
  • Add PGP key

Approved by: jtl (mentor)

Diff Detail

rD FreeBSD doc repository - subversion
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jtl requested changes to this revision.Apr 11 2018, 5:06 PM
jtl added inline comments.
581 ↗(On Diff #41369)

I think this should go above mjoras to meet the criteria (alphabetical order by last name).

1009 ↗(On Diff #41369)

Again, I believe this should be above mjoras.

34 ↗(On Diff #41369)

This needs to move into the <month> block. Because things are in reverse-chronological order, the <day> block for 7 April should be before the block for 4 April.

This revision now requires changes to proceed.Apr 11 2018, 5:06 PM

Move my entries to above mjoras

Move news.xml entry into the month block

Looks good. Please check on two things before committing:

  1. I don't see a svn:keywords property change for head/share/pgpkeys/thj.key. I expected to see one, although this could just be a Phabricator display issue. Can you confirm you've followed the instructions in the Note at the start of 5.3.7 of the Committer's Guide ("Adding and Removing Files")? If not, please do so and then svn remove and svn add the file again. You can check that the property was correctly applied by running this command: svn propget svn:keywords thj.key. You should see FreeBSD=%H.
  2. Please check on the indentation in news.xml. (See in-line note.)
44 ↗(On Diff #41375)

The indenting looks funky here (for the </event> line), but that could be a Phabricator display issue. Can you double check that it uses the same indenting (including tabs vs. spaces) as the <event> line prior to committing?


This revision is now accepted and ready to land.Apr 11 2018, 5:45 PM

Make the indentation in for "event" blocks news.xml match. It was equal number of spaces to tabs, now is tabs.

The "svn:keywords" property was not being set as there is no auto-props entry for key files in the example from 5.3.7 of the committers guide.

Set "svn:keywords" property to "" (empty string) rather than "FreeBSD=%H". As that is what the majority of the other keys in share/pgpkeys have.

This revision now requires review to proceed.Apr 11 2018, 8:28 PM
This revision is now accepted and ready to land.Apr 11 2018, 10:54 PM
This revision was automatically updated to reflect the committed changes.