0.07
ClosedPublic
Actions

Authored by bofh on Jan 10 2015, 11:43 AM.

Details

Reviewers

bapt
marino

Summary

Pass Maintainership[1]

PR: 196560[1]
Differential Revision: https://reviews.freebsd.org/DXXXX
Submitted by: pauls@utdallas.edu
Approved by: xxxx(mentor)

Test Plan

http://pdr.s.ubze.ro/bulk/latest-per-pkg/p5-Net-Abuse-Utils-Spamhaus/0.07/

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

bofh updated this revision to Diff 3088.Jan 10 2015, 11:43 AM

bofh retitled this revision from to net-mgmt/p5-Net-Abuse-Utils-Spamhaus: Update version 0.04=>0.07.

bofh updated this object.

bofh edited the test plan for this revision. (Show Details)

bofh added reviewers: bapt, marino.

bofh set the repository for this revision to rP FreeBSD ports repository.

You need a space before "[1]" on both lines, especially the PR: line because the dfilter might not work without it.
So approved with that minor change to commit message.

This revision is now accepted and ready to land.Jan 10 2015, 11:46 AM

If multiple PRs related to a single port is submitted by multiple persons and if I combine them all should I also mention all the "Submitted by:" with annotations like this [1], [2] etc.

yes

In D1481#8, @bapt wrote:

yes

Thanks.

if they are from the same persion, you can put them all on one line, e.g.

Submitted by: Bob Smith [1][2]

However, I would use 1 line per PR: because dflilter since has some quirks in it.

In D1481#11, @marino wrote:

if they are from the same persion, you can put them all on one line, e.g.

Submitted by: Bob Smith [1][2]

However, I would use 1 line per PR: because dflilter since has some quirks in it.

Noted.