Page MenuHomeFreeBSD
Differential D14574

bsdinstall(8): partedit crashes when modifying a zfs partition's mountpoint
Needs ReviewPublic
Actions

Authored by will_worrbase.com on Mar 3 2018, 8:47 AM.
Tags
None
Referenced Files
F134678618: D14574.diff
Mon, Nov 3, 11:49 PM
Unknown Object (File)
Sun, Nov 2, 2:09 PM
Unknown Object (File)
Sun, Oct 26, 12:42 AM
Unknown Object (File)
Sat, Oct 25, 3:28 AM
Unknown Object (File)
Tue, Oct 21, 12:33 AM
Unknown Object (File)
Tue, Oct 21, 12:33 AM
Unknown Object (File)
Mon, Oct 20, 2:44 PM
Unknown Object (File)
Mon, Oct 6, 1:00 PM
View All 90 Files
Subscribers
imp
Contributor Reviews (src)
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

bsdinstall(8): partedit crashes when modifying a zfs partition's
mountpoint

When modifying a ZFS partition to change the mountpoint (or pool name, really),
zpool_name isn't set, causing partedit to crash.

Also removed a useless NULL check.

Test Plan

Tested by modifying an existing ZFS mountpoint in bsdinstall(8)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15352
Build 15407: arc lint + arc unit

Revision Contents
Changeset List

PathSize
usr.sbin/
bsdinstall/
partedit/
16 lines

Diff 39913

View Options

usr.sbin/bsdinstall/partedit/gpart_ops.c

Loading...