bsdinstall(8): partedit crashes when modifying a zfs partition's mountpoint
Needs ReviewPublic
Actions

Authored by will_worrbase.com on Mar 3 2018, 8:47 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Sep 5, 7:13 PM

	Unknown Object (File)
	Sat, Sep 5, 11:01 AM

	Unknown Object (File)
	Thu, Sep 3, 8:56 AM

	Unknown Object (File)
	Tue, Sep 1, 12:43 PM

	Unknown Object (File)
	Tue, Sep 1, 8:42 AM

	Unknown Object (File)
	Wed, Aug 26, 2:49 AM

	Unknown Object (File)
	Aug 23 2026, 6:12 AM

	Unknown Object (File)
	Aug 12 2026, 7:00 PM

View All Files

Subscribers

imp

Contributor Reviews (src)

This revision needs review, but there are no reviewers specified.

Details

Reviewers: None

Summary

bsdinstall(8): partedit crashes when modifying a zfs partition's
mountpoint

When modifying a ZFS partition to change the mountpoint (or pool name, really),
zpool_name isn't set, causing partedit to crash.

Also removed a useless NULL check.

Test Plan

Tested by modifying an existing ZFS mountpoint in bsdinstall(8)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15352
Build 15407: arc lint + arc unit

Event Timeline

will_worrbase.com created this revision.Mar 3 2018, 8:47 AM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptMar 3 2018, 8:47 AM

Harbormaster completed remote builds in B15352: Diff 39913.Mar 3 2018, 8:47 AM

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205828

Revision Contents
Changeset List

Path

Size

usr.sbin/

bsdinstall/

partedit/

gpart_ops.c

16 lines

Diff 39913

View Options

usr.sbin/bsdinstall/partedit/gpart_ops.c

bsdinstall(8): partedit crashes when modifying a zfs partition's mountpointNeeds ReviewPublicActions