bsdinstall(8): partedit crashes when modifying a zfs partition's mountpoint
Needs ReviewPublic
Actions

Authored by will_worrbase.com on Mar 3 2018, 8:47 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 3, 5:19 PM

	Unknown Object (File)
	Wed, Apr 29, 9:34 PM

	Unknown Object (File)
	Tue, Apr 21, 6:12 PM

	Unknown Object (File)
	Mon, Apr 20, 2:25 AM

	Unknown Object (File)
	Mon, Apr 20, 12:22 AM

	Unknown Object (File)
	Sun, Apr 19, 7:10 PM

	Unknown Object (File)
	Sun, Apr 19, 7:09 PM

	Unknown Object (File)
	Mar 25 2026, 6:10 AM

View All Files

Subscribers

imp

Contributor Reviews (src)

This revision needs review, but there are no reviewers specified.

Details

Reviewers: None

Summary

bsdinstall(8): partedit crashes when modifying a zfs partition's
mountpoint

When modifying a ZFS partition to change the mountpoint (or pool name, really),
zpool_name isn't set, causing partedit to crash.

Also removed a useless NULL check.

Test Plan

Tested by modifying an existing ZFS mountpoint in bsdinstall(8)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15352
Build 15407: arc lint + arc unit

Event Timeline

will_worrbase.com created this revision.Mar 3 2018, 8:47 AM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptMar 3 2018, 8:47 AM

Harbormaster completed remote builds in B15352: Diff 39913.Mar 3 2018, 8:47 AM

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205828

Revision Contents
Changeset List

Path

Size

usr.sbin/

bsdinstall/

partedit/

gpart_ops.c

16 lines

Diff 39913

View Options

usr.sbin/bsdinstall/partedit/gpart_ops.c

bsdinstall(8): partedit crashes when modifying a zfs partition's mountpointNeeds ReviewPublicActions