Differential D14550

getpatch: do not download obsolete attachments
ClosedPublic
Actions

Authored by gonzo on Mar 1 2018, 6:39 AM.

Details

Reviewers

sbz

Commits

rP470568: - Do not download obsolete attachments

Test Plan

run "Tools/scripts/getpatch 193920"
Only one "[+] patch-uTox.diff created" should message should be printed

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gonzo created this revision.Mar 1 2018, 6:39 AM

Herald added a subscriber: mat. · View Herald TranscriptMar 1 2018, 6:39 AM

Harbormaster completed remote builds in B15321: Diff 39848.Mar 1 2018, 6:39 AM

Thank you for working on that @gonzo!

LGTM

This revision is now accepted and ready to land.May 16 2018, 8:31 PM

Thanks for reviewing Sofian.

Will you commit the change or do I have your approval to commit it to prts repo? (I am not ports committer, so I need someone with ports bit to approve the change)

Thanks

Ok, in this case, I will commit it later.

Closed by commit rP470568: - Do not download obsolete attachments (authored by sbz). · Explain WhyMay 21 2018, 6:57 PM

This revision was automatically updated to reflect the committed changes.

@gonzo FYI I applied, tested and it looks like the changes had formatting issues (tab/space) with python3.x (which have a parser more strict than python2.x):

python3 getpatch 
  File "getpatch", line 167
    if match is None:
                    ^
TabError: inconsistent use of tabs and spaces in indentation

I fixed them before commit. Committed in r470568. Thank you!

Revision Contents
Changeset List

Path

Size

head/

Tools/

scripts/

getpatch

18 lines

Diff 42809

View Options

head/Tools/scripts/getpatch

getpatch: do not download obsolete attachmentsClosedPublicActions