Page MenuHomeFreeBSD
Differential D1441

Handle the TSC sometimes stopping on older Intel CPUs with C2 by disabling both C2 and C3 if the TSC is used as the timecounter on these CPUs.
ClosedPublic
Actions

Authored by jhb on Jan 5 2015, 6:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 21, 12:15 PM
Unknown Object (File)
Mon, Apr 7, 1:39 AM
Unknown Object (File)
Mar 7 2025, 10:59 AM
Unknown Object (File)
Feb 23 2025, 12:25 PM
Unknown Object (File)
Feb 23 2025, 11:21 AM
Unknown Object (File)
Jan 6 2025, 11:36 PM
Unknown Object (File)
Dec 31 2024, 2:10 PM
Unknown Object (File)
Dec 2 2024, 8:07 AM
View All 83 Files
Subscribers
None

Details

Reviewers
jkim
jhb
Summary

PR: 192316

Test Plan

Bug submitter tested this on a laptop that reported C3 as C2 (it
seems) when power management settings were changed in the BIOS.
This does disable C2 on some systems where it would be safe, but
all newer systems have a C-state invariant TSC which are not
affected by this change.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

jhb updated this revision to Diff 3003.Jan 5 2015, 6:02 PM
jhb retitled this revision from to Handle the TSC sometimes stopping on older Intel CPUs with C2 by disabling both C2 and C3 if the TSC is used as the timecounter on these CPUs..
jhb edited the test plan for this revision. (Show Details)
jhb added a reviewer: jkim.
jhb updated this object.
jhb accepted this revision.Jan 29 2015, 4:47 PM
jhb added a reviewer: jhb.
This revision is now accepted and ready to land.Jan 29 2015, 4:47 PM
jhb closed this revision.Jan 29 2015, 4:47 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
2 lines
dev/
acpica/
17 lines
i386/
i386/
2 lines
kern/
11 lines
8 lines
sys/
5 lines
2 lines
x86/
x86/
12 lines

Diff 3003

View Options

sys/amd64/amd64/machdep.c

Show First 20 Lines • Show All 3,009 Lines • ▼ Show 20 Lines
.if (defined(IS_INTERACTIVE) && defined(BATCH)) .if (defined(IS_INTERACTIVE) && defined(BATCH))
IGNORE= is an interactive port IGNORE= is an interactive port
.elif (!defined(IS_INTERACTIVE) && defined(INTERACTIVE)) .elif (!defined(IS_INTERACTIVE) && defined(INTERACTIVE))
IGNORE= is not an interactive port IGNORE= is not an interactive port
.elif (defined(NO_CDROM) && defined(FOR_CDROM)) .elif (defined(NO_CDROM) && defined(FOR_CDROM))
IGNORE= may not be placed on a CDROM: ${NO_CDROM} IGNORE= may not be placed on a CDROM: ${NO_CDROM}
.elif (defined(RESTRICTED) && defined(NO_RESTRICTED)) .elif (defined(RESTRICTED) && defined(NO_RESTRICTED))
IGNORE= is restricted: ${RESTRICTED} IGNORE= is restricted: ${RESTRICTED}
.elif (defined(NO_PACKAGE) && defined(PACKAGE_BUILDING))
IGNORE= may not be packaged: ${NO_PACKAGE}
.elif defined(BROKEN) .elif defined(BROKEN)
.if !defined(TRYBROKEN) .if !defined(TRYBROKEN)
IGNORE= is marked as broken: ${BROKEN} IGNORE= is marked as broken: ${BROKEN}
.endif .endif
.elif defined(BROKEN_${ARCH}) .elif defined(BROKEN_${ARCH})
.if !defined(TRYBROKEN) .if !defined(TRYBROKEN)
IGNORE= is marked as broken on ${ARCH}: ${BROKEN_${ARCH}} IGNORE= is marked as broken on ${ARCH}: ${BROKEN_${ARCH}}
.endif .endif
▲ Show 20 Lines • Show All 3,554 Lines • Show Last 20 Lines
View Options

sys/dev/acpica/acpi_cpu.c

Show First 20 Lines • Show All 3,009 Lines • ▼ Show 20 Lines
.if (defined(IS_INTERACTIVE) && defined(BATCH)) .if (defined(IS_INTERACTIVE) && defined(BATCH))
IGNORE= is an interactive port IGNORE= is an interactive port
.elif (!defined(IS_INTERACTIVE) && defined(INTERACTIVE)) .elif (!defined(IS_INTERACTIVE) && defined(INTERACTIVE))
IGNORE= is not an interactive port IGNORE= is not an interactive port
.elif (defined(NO_CDROM) && defined(FOR_CDROM)) .elif (defined(NO_CDROM) && defined(FOR_CDROM))
IGNORE= may not be placed on a CDROM: ${NO_CDROM} IGNORE= may not be placed on a CDROM: ${NO_CDROM}
.elif (defined(RESTRICTED) && defined(NO_RESTRICTED)) .elif (defined(RESTRICTED) && defined(NO_RESTRICTED))
IGNORE= is restricted: ${RESTRICTED} IGNORE= is restricted: ${RESTRICTED}
.elif (defined(NO_PACKAGE) && defined(PACKAGE_BUILDING))
IGNORE= may not be packaged: ${NO_PACKAGE}
.elif defined(BROKEN) .elif defined(BROKEN)
.if !defined(TRYBROKEN) .if !defined(TRYBROKEN)
IGNORE= is marked as broken: ${BROKEN} IGNORE= is marked as broken: ${BROKEN}
.endif .endif
.elif defined(BROKEN_${ARCH}) .elif defined(BROKEN_${ARCH})
.if !defined(TRYBROKEN) .if !defined(TRYBROKEN)
IGNORE= is marked as broken on ${ARCH}: ${BROKEN_${ARCH}} IGNORE= is marked as broken on ${ARCH}: ${BROKEN_${ARCH}}
.endif .endif
▲ Show 20 Lines • Show All 3,554 Lines • Show Last 20 Lines
View Options

sys/i386/i386/machdep.c

Show First 20 Lines • Show All 3,009 Lines • ▼ Show 20 Lines
.if (defined(IS_INTERACTIVE) && defined(BATCH)) .if (defined(IS_INTERACTIVE) && defined(BATCH))
IGNORE= is an interactive port IGNORE= is an interactive port
.elif (!defined(IS_INTERACTIVE) && defined(INTERACTIVE)) .elif (!defined(IS_INTERACTIVE) && defined(INTERACTIVE))
IGNORE= is not an interactive port IGNORE= is not an interactive port
.elif (defined(NO_CDROM) && defined(FOR_CDROM)) .elif (defined(NO_CDROM) && defined(FOR_CDROM))
IGNORE= may not be placed on a CDROM: ${NO_CDROM} IGNORE= may not be placed on a CDROM: ${NO_CDROM}
.elif (defined(RESTRICTED) && defined(NO_RESTRICTED)) .elif (defined(RESTRICTED) && defined(NO_RESTRICTED))
IGNORE= is restricted: ${RESTRICTED} IGNORE= is restricted: ${RESTRICTED}
.elif (defined(NO_PACKAGE) && defined(PACKAGE_BUILDING))
IGNORE= may not be packaged: ${NO_PACKAGE}
.elif defined(BROKEN) .elif defined(BROKEN)
.if !defined(TRYBROKEN) .if !defined(TRYBROKEN)
IGNORE= is marked as broken: ${BROKEN} IGNORE= is marked as broken: ${BROKEN}
.endif .endif
.elif defined(BROKEN_${ARCH}) .elif defined(BROKEN_${ARCH})
.if !defined(TRYBROKEN) .if !defined(TRYBROKEN)
IGNORE= is marked as broken on ${ARCH}: ${BROKEN_${ARCH}} IGNORE= is marked as broken on ${ARCH}: ${BROKEN_${ARCH}}
.endif .endif
▲ Show 20 Lines • Show All 3,554 Lines • Show Last 20 Lines
View Options

sys/kern/kern_clocksource.c

Show First 20 Lines • Show All 3,009 Lines • ▼ Show 20 Lines
.if (defined(IS_INTERACTIVE) && defined(BATCH)) .if (defined(IS_INTERACTIVE) && defined(BATCH))
IGNORE= is an interactive port IGNORE= is an interactive port
.elif (!defined(IS_INTERACTIVE) && defined(INTERACTIVE)) .elif (!defined(IS_INTERACTIVE) && defined(INTERACTIVE))
IGNORE= is not an interactive port IGNORE= is not an interactive port
.elif (defined(NO_CDROM) && defined(FOR_CDROM)) .elif (defined(NO_CDROM) && defined(FOR_CDROM))
IGNORE= may not be placed on a CDROM: ${NO_CDROM} IGNORE= may not be placed on a CDROM: ${NO_CDROM}
.elif (defined(RESTRICTED) && defined(NO_RESTRICTED)) .elif (defined(RESTRICTED) && defined(NO_RESTRICTED))
IGNORE= is restricted: ${RESTRICTED} IGNORE= is restricted: ${RESTRICTED}
.elif (defined(NO_PACKAGE) && defined(PACKAGE_BUILDING))
IGNORE= may not be packaged: ${NO_PACKAGE}
.elif defined(BROKEN) .elif defined(BROKEN)
.if !defined(TRYBROKEN) .if !defined(TRYBROKEN)
IGNORE= is marked as broken: ${BROKEN} IGNORE= is marked as broken: ${BROKEN}
.endif .endif
.elif defined(BROKEN_${ARCH}) .elif defined(BROKEN_${ARCH})
.if !defined(TRYBROKEN) .if !defined(TRYBROKEN)
IGNORE= is marked as broken on ${ARCH}: ${BROKEN_${ARCH}} IGNORE= is marked as broken on ${ARCH}: ${BROKEN_${ARCH}}
.endif .endif
▲ Show 20 Lines • Show All 3,554 Lines • Show Last 20 Lines
View Options

sys/kern/kern_tc.c

Loading...
View Options

sys/sys/systm.h

Loading...
View Options

sys/sys/timetc.h

Loading...
View Options

sys/x86/x86/tsc.c

Loading...