Page MenuHomeFreeBSD

Have `make clean` clean all flavors, and get a make clean-foo cleaning flavor foo.
Needs RevisionPublic

Authored by mat on Jan 29 2018, 4:24 PM.
Tags
None
Referenced Files
F86855543: D14117.id38668.diff
Wed, Jun 26, 3:18 PM
Unknown Object (File)
May 22 2024, 6:15 AM
Unknown Object (File)
May 22 2024, 3:03 AM
Unknown Object (File)
May 22 2024, 2:11 AM
Unknown Object (File)
May 21 2024, 2:32 PM
Unknown Object (File)
May 19 2024, 9:31 AM
Unknown Object (File)
Mar 22 2024, 1:57 AM
Unknown Object (File)
Dec 23 2023, 3:17 AM
Subscribers
None

Details

Reviewers
jhale
Group Reviewers
portmgr

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 14653
Build 14783: arc lint + arc unit

Event Timeline

Looks good to me. Thank you!

This revision is now accepted and ready to land.Jan 30 2018, 9:40 AM
  • Add the flavor being cleaned if there is one.
This revision now requires review to proceed.Jan 30 2018, 12:13 PM
jhale requested changes to this revision.Feb 1 2018, 1:34 AM
jhale added inline comments.
Mk/bsd.port.mk
3764

For non-flavored ports, that seems to leave the message as, for example: ===> Cleaning for gnupg-2.2.4 flavor

Perhaps use: @${ECHO_MSG} "===> Cleaning for ${PKGNAME}${"${FLAVOR}" != "" :? flavor ${FLAVOR}:}"

This revision now requires changes to proceed.Feb 1 2018, 1:34 AM
Mk/bsd.port.mk
3764

Mmmm :? is suppsed to be "if variable is true" I thought an empty string was false, never mind, I'll remove this.