Have `make clean` clean all flavors, and get a make clean-foo cleaning flavor foo.
Needs RevisionPublic
Actions

Authored by mat on Jan 29 2018, 4:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mar 22 2024, 1:57 AM

	Unknown Object (File)
	Dec 23 2023, 3:17 AM

	Unknown Object (File)
	Dec 15 2023, 6:21 AM

	Unknown Object (File)
	Nov 15 2023, 4:07 PM

	Unknown Object (File)
	Nov 10 2023, 11:29 AM

	Unknown Object (File)
	Nov 9 2023, 2:04 PM

	Unknown Object (File)
	Nov 5 2023, 2:28 AM

	Unknown Object (File)
	Oct 14 2023, 3:11 PM

View All 17 Files

Subscribers

None

Details

Reviewers

jhale

Group Reviewers

portmgr

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 14669
Build 14798: arc lint + arc unit

Event Timeline

mat created this revision.Jan 29 2018, 4:24 PM

Looks good to me. Thank you!

This revision is now accepted and ready to land.Jan 30 2018, 9:40 AM

Add the flavor being cleaned if there is one.

This revision now requires review to proceed.Jan 30 2018, 12:13 PM

Harbormaster completed remote builds in B14669: Diff 38668.Jan 30 2018, 12:13 PM

jhale requested changes to this revision.Feb 1 2018, 1:34 AM

jhale added inline comments.

Mk/bsd.port.mk
3764	For non-flavored ports, that seems to leave the message as, for example: ===> Cleaning for gnupg-2.2.4 flavor Perhaps use: @${ECHO_MSG} "===> Cleaning for ${PKGNAME}${"${FLAVOR}" != "" :? flavor ${FLAVOR}:}"

This revision now requires changes to proceed.Feb 1 2018, 1:34 AM

mat added inline comments.Feb 1 2018, 8:31 AM

Mk/bsd.port.mk
3764	Mmmm :? is suppsed to be "if variable is true" I thought an empty string was false, never mind, I'll remove this.

Revision Contents
Changeset List

Path

Size

Mk/

bsd.port.mk

10 lines

Diff 38668

View Options

Have `make clean` clean all flavors, and get a make clean-foo cleaning flavor foo.Needs RevisionPublicActions