Page MenuHomeFreeBSD
Differential D13998

multimedia/libv4l: Fix direction for `EVIOCGMTSLOTS` ioctl
AbandonedPublic
Actions

Authored by dumbbell on Jan 20 2018, 7:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 2:25 PM
Unknown Object (File)
Fri, Apr 19, 2:25 PM
Unknown Object (File)
Fri, Apr 19, 2:25 PM
Unknown Object (File)
Fri, Apr 19, 2:25 PM
Unknown Object (File)
Thu, Apr 18, 1:27 PM
Unknown Object (File)
Sat, Apr 13, 1:19 AM
Unknown Object (File)
Tue, Apr 9, 10:47 AM
Unknown Object (File)
Tue, Apr 9, 10:46 AM
View All 33 Files
Subscribers
mat

Details

Reviewers
kwm
Summary

This is an evdev ioctl used to query a touchpad's multitouch state. On Linux it's marked as "read", but it passes the code of the attribute to get: on FreeBSD this requires the ioctl to be "read+write" otherwise the userland data does't make it to the kernel driver.

Without this, the evdev kernel driver returns EINVAL because it doesn't recognized the ioctl.

Bugzilla PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225343

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 14543
Build 14682: arc lint + arc unit

Event Timeline

dumbbell created this revision.Jan 20 2018, 7:00 PM
Herald added a subscriber: mat. · View Herald TranscriptJan 20 2018, 7:00 PM
Harbormaster completed remote builds in B14504: Diff 38256.Jan 20 2018, 7:00 PM
dumbbell edited the summary of this revision. (Show Details)Jan 20 2018, 7:01 PM
dumbbell edited the summary of this revision. (Show Details)
mat added inline comments.Jan 22 2018, 2:48 PM
multimedia/libv4l/files/patch-contrib_freebsd_include_linux_input.h
2

Could you add a small comment at the top of the patch explaining what it does ?

dumbbell updated this revision to Diff 38369.Jan 23 2018, 10:58 PM

Add a description to the patch

Harbormaster completed remote builds in B14538: Diff 38369.Jan 23 2018, 10:58 PM
dumbbell added a comment.Jan 23 2018, 11:00 PM

@mat: Done, thanks!

Quick question: devel/libevdev needs to be recompiled. Do I need to bump libevdev's PORTREVISION or is it detected automatically?

mat added a comment.Jan 24 2018, 9:54 AM

bump.

dumbbell updated this revision to Diff 38382.Jan 24 2018, 10:26 AM

Bump libevdev PORTREVISION

Harbormaster completed remote builds in B14543: Diff 38382.Jan 24 2018, 10:26 AM
dumbbell abandoned this revision.Jan 26 2018, 10:16 AM

There is another more complete patch attached to the following PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217248

Revision Contents
Changeset List

PathSize
devel/
libevdev/
1 line
multimedia/
libv4l/
2 lines
files/
18 lines
v4l_compat/
2 lines

Diff 38382

View Options

devel/libevdev/Makefile

Loading...
View Options

multimedia/libv4l/Makefile

Loading...
View Options

multimedia/libv4l/files/patch-contrib_freebsd_include_linux_input.h

Loading...
View Options

multimedia/v4l_compat/Makefile

Loading...