Page MenuHomeFreeBSD

multimedia/libv4l: Fix direction for `EVIOCGMTSLOTS` ioctl
AbandonedPublic

Authored by dumbbell on Jan 20 2018, 7:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 9, 8:55 AM
Unknown Object (File)
Mon, Oct 6, 8:15 AM
Unknown Object (File)
Mon, Sep 29, 2:29 AM
Unknown Object (File)
Sat, Sep 27, 11:09 AM
Unknown Object (File)
Sat, Sep 27, 2:50 AM
Unknown Object (File)
Sat, Sep 27, 2:20 AM
Unknown Object (File)
Sep 12 2025, 1:37 AM
Unknown Object (File)
Aug 23 2025, 7:28 AM
Subscribers

Details

Reviewers
kwm
Summary

This is an evdev ioctl used to query a touchpad's multitouch state. On Linux it's marked as "read", but it passes the code of the attribute to get: on FreeBSD this requires the ioctl to be "read+write" otherwise the userland data does't make it to the kernel driver.

Without this, the evdev kernel driver returns EINVAL because it doesn't recognized the ioctl.

Bugzilla PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225343

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 14543
Build 14682: arc lint + arc unit

Event Timeline

dumbbell edited the summary of this revision. (Show Details)
multimedia/libv4l/files/patch-contrib_freebsd_include_linux_input.h
2

Could you add a small comment at the top of the patch explaining what it does ?

Add a description to the patch

@mat: Done, thanks!

Quick question: devel/libevdev needs to be recompiled. Do I need to bump libevdev's PORTREVISION or is it detected automatically?

There is another more complete patch attached to the following PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217248