Page MenuHomeFreeBSD

devel/libspice-server: fix pc file generation

Authored by novel on Jan 13 2018, 4:42 AM.



libspice-server uses autotools and utilizes PKG_CHECK_MODULES to get openssl CFLAGS and LDFLAGS.
However, as we support various openssl flavors, including openssl from base that lacks pkg-config file, we
explicitly pass OPENSSL_LIBS and OPENSSL_CFLAGS via CONFIGURE_ENV, however, libspice-server
still adds 'openssl' package to Requires.private of its .pc file.

This causes a problem for software that requires libspice-server, because e.g. when using openssl from base,
detection will fail because .pc file is listing non-existent 'openssl' package.

To fix that, update libspice-server's to add 'openssl' to Requires.private only if OPENSSL_LIBS and OPENSSL_CFLAGS wasn't explicitly specified by user, otherwise omit 'openssl' and just add the value of OPENSSL_LIBS to Libs.private.

While here, add 'amd64' to list of x86_64 cpus so it don't show a warning.

Diff Detail

rP FreeBSD ports repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

novel created this revision.Jan 13 2018, 4:42 AM
novel edited the summary of this revision. (Show Details)Jan 13 2018, 4:43 AM

@novel I checked this patch on my system and it looks good for me.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 16 2018, 5:42 PM
Closed by commit rP459198: devel/libspice-server: fix pc file generation (authored by novel, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.