Page MenuHomeFreeBSD

benchmarks/siege: update to 3.0.9
ClosedPublic

Authored by bofh on Dec 28 2014, 7:17 PM.

Details

Reviewers
bapt
marino
Summary

net/ntopng: update to 3.0.9

  • update to 3.0.9

Differential Revision: https://reviews.freebsd.org/D1389
Approved by: xxx(mentor)

Test Plan

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

bofh updated this revision to Diff 2900.Dec 28 2014, 7:17 PM
bofh retitled this revision from to benchmarks/siege: update to 3.0.9.
bofh updated this object.
bofh edited the test plan for this revision. (Show Details)
bofh added reviewers: bapt, marino.
bofh set the repository for this revision to rP FreeBSD ports repository.
bofh updated this object.
bapt accepted this revision.Dec 28 2014, 7:23 PM
bapt edited edge metadata.
This revision is now accepted and ready to land.Dec 28 2014, 7:23 PM
marino accepted this revision.Dec 28 2014, 7:26 PM
marino edited edge metadata.

The commit is approved.

I think the commit message could be improved:

  1. the bullet "update to 3.0.9" is redundant with the title, so I think it can be eliminated entirely
  2. when I update, i include the current version in the commit message. If it were me, the message would look like:

net/ntopng: update version 3.0.8 => 3.0.9

Differential Revision: https://reviews.freebsd.org/D1389
Approved by: marino (mentor)

bofh closed this revision.Dec 29 2014, 7:02 AM