Page MenuHomeFreeBSD

Add shell completion section to PHB

Authored by adamw on Dec 30 2017, 7:16 PM.


  • Always install shell completion files
  • Don't register dependencies

I've not edited docproj stuff before, so I could really use some eyes here.

Diff Detail

rD FreeBSD doc repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

adamw created this revision.Dec 30 2017, 7:16 PM
mat added inline comments.Dec 30 2017, 8:13 PM
5538–5540 ↗(On Diff #37242)

OPTION is not a variable, so, lowercase it and remove the tag.

Also, never address the porter directly with "you", and keep sentences short, so, maybe something like:

It is not necessary to add an option for it.
If an option is added though, always enable it
in <varname>OPTIONS_DEFAULT</varname>.

Or some variation on it, your english is better than mine :-)

5549 ↗(On Diff #37242)

Maybe remove the / at the end of the path, it is already a path, no need to add the extra delimiter at the end. (Same for the zsh path.)

5560–5561 ↗(On Diff #37242)

extra new line after the end of the sentence.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 30 2017, 8:51 PM
This revision was automatically updated to reflect the committed changes.