Page MenuHomeFreeBSD

loader.efi: Don't fail if we cannot find the current device

Authored by manu on Dec 21 2017, 8:07 PM.



While failing might seems ok, just warning the person and drop to
interact is better as he can debug stuff.

Diff Detail

Lint OK
No Unit Test Coverage
Build Status
Buildable 13730
Build 13950: arc lint + arc unit

Event Timeline

manu created this revision.Dec 21 2017, 8:07 PM
imp requested changes to this revision.Dec 21 2017, 9:16 PM

I believe that this violates the UEFI Boot Manager Spec. If you fail for any reason, you have to return failure, not drop into the debugger...

So what brought you to want this change? What's the use case where this is useful? Perhaps there's a way we can detect when we're not participating in the boot manager protocol and just warn in that case.

This revision now requires changes to proceed.Dec 21 2017, 9:16 PM
manu abandoned this revision.Jan 1 2018, 2:05 PM

This is a hack, I'll keep it locally if I need it.