Page MenuHomeFreeBSD

Various 8259 device model improvements.
ClosedPublic

Authored by neel on Dec 17 2014, 6:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 10:58 PM
Unknown Object (File)
Oct 14 2024, 7:03 PM
Unknown Object (File)
Oct 14 2024, 7:02 PM
Unknown Object (File)
Oct 14 2024, 6:44 PM
Unknown Object (File)
Oct 2 2024, 11:48 PM
Unknown Object (File)
Oct 2 2024, 9:18 PM
Unknown Object (File)
Sep 30 2024, 2:28 PM
Unknown Object (File)
Sep 30 2024, 11:20 AM
Subscribers
None

Details

Summary

Various 8259 device model improvements:

  • implement 8259 "polled" mode.
  • set 'atpic->sfn' if bit 4 in ICW4 is set during master initialization.
  • report error if guest tries to enable the "special mask" mode.

Reported and tested by Peter Grehan (grehan@).

Test Plan

Prior to this change, when installing Centos4.8/i386, bhyve exits due to an
unhandled i/o port access. This was tracked down to the vatpic, with polled
mode not being implemented.

After this change the installation works as expected.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

neel retitled this revision from to Various 8259 device model improvements..
neel updated this object.
neel edited the test plan for this revision. (Show Details)
neel added reviewers: tychon, grehan, jhb.
tychon edited edge metadata.

So odd that SFN was implemented minus the ability to actually enable it. Seems like the priority to commit jumped the priority to complete ;-)

Thanks for finishing it! The changes look good to me.

This revision is now accepted and ready to land.Dec 19 2014, 3:24 PM