Page MenuHomeFreeBSD

Do not strip all when stripping an explicit symbol
ClosedPublic

Authored by emaste on Dec 16 2014, 10:44 PM.

Details

Summary

When asked to strip a specific symbol (-N) elftoolchain strip still defaulted to STRIP_ALL. In this case binutils defaults to stripping nothing (other than the requested symbol(s), of course), which makes a lot more sense.

PR 196038
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196038

Test Plan
  • reduced test case from PR
  • build ffmpeg port

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

emaste updated this revision to Diff 2767.Dec 16 2014, 10:44 PM
emaste retitled this revision from to Do not strip all when stripping an explicit symbol.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste updated this object.
emaste added a subscriber: Unknown Object (MLST).
imp accepted this revision.Dec 16 2014, 10:50 PM
imp added a reviewer: imp.
imp added a subscriber: imp.

Looks good to me.

This revision is now accepted and ready to land.Dec 16 2014, 10:50 PM
emaste closed this revision.Dec 17 2014, 2:46 PM
emaste updated this revision to Diff 2778.

Closed by commit rS275862 (authored by @emaste).