Do not strip all when stripping an explicit symbol
ClosedPublic
Actions

Authored by emaste on Dec 16 2014, 10:44 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 22, 6:57 AM

	Unknown Object (File)
	Thu, Dec 19, 11:29 PM

	Unknown Object (File)
	Fri, Nov 29, 6:45 PM

	Unknown Object (File)
	Tue, Nov 26, 12:15 AM

	Unknown Object (File)
	Oct 26 2024, 2:43 PM

	Unknown Object (File)
	Oct 19 2024, 2:04 PM

	Unknown Object (File)
	Oct 19 2024, 2:04 PM

	Unknown Object (File)
	Oct 19 2024, 2:04 PM

View All 76 Files

Subscribers

freebsd-toolchain-list

imp

Details

Reviewers

imp

Commits

rS275862: Do not strip all when stripping an explicit symbol

Summary

When asked to strip a specific symbol (-N) elftoolchain strip still defaulted to STRIP_ALL. In this case binutils defaults to stripping nothing (other than the requested symbol(s), of course), which makes a lot more sense.

PR 196038
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196038

Test Plan

reduced test case from PR
build ffmpeg port

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 2767.Dec 16 2014, 10:44 PM

emaste retitled this revision from to Do not strip all when stripping an explicit symbol.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste updated this object.

emaste added a subscriber: Unknown Object (MLST).

Looks good to me.

This revision is now accepted and ready to land.Dec 16 2014, 10:50 PM

Closed by commit rS275862 (authored by @emaste).

Revision Contents
Changeset List

Path

Size

head/

contrib/

elftoolchain/

elfcopy/

main.c

3 lines

Diff 2778

View Options

head/contrib/elftoolchain/elfcopy/main.c

Do not strip all when stripping an explicit symbolClosedPublicActions