Page MenuHomeFreeBSD

net/shadowsocks-libev: Update to 3.1.0
ClosedPublic

Authored by ygy on Nov 15 2017, 7:59 AM.

Details

Summary
net/shadowsocks-libev: Update to 3.1.0

PR: 218294
Submitted by: Anonymous contributor
Approved by: xiaoding+freebsd@xiaoding.org (maintainer timeout), adamw
Differential_Revision: https://reviews.freebsd.org/D13099
Test Plan

portlint: OK
testport: OK (11.1-RELEASE amd64, 10.4-RELEASE i386)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ygy edited the summary of this revision. (Show Details)
net/shadowsocks-libev/Makefile
27 ↗(On Diff #35268)

Are none of these available as actual tagged releases?

31 ↗(On Diff #35268)

Things that use large dependencies to build the docs shouldn't be under a DOCS option. It's better to put them under an ASCIIDOCS option, so that people know they'll be installing asciidoc when it's on.

36 ↗(On Diff #35268)

As long as --enable-documentation works to, this should be

DOCS_CONFIGURE_ENABLE=    documentation
zhoushuqun_gmail.com added inline comments.
net/shadowsocks-libev/Makefile
27 ↗(On Diff #35268)

No tagged releases for the revisions that this port depends on.

$ git submodule status
-7a9deb893fc1646c0b9186b50d46358379953d4b libbloom
-0220aa5a2d11b7484b4aa464024ba8b6942d646f libcork
-3ea7fe30adf4b39b27d932e5a70a2ddce4adb508 libipset

libbloom 7a9deb8(Feb 28, 2017) no tag(the newest tag is v1.3 at 402cc21 on Oct 18, 2016)
libcork 0220aa5(Feb 22, 2017) no tag(the newest tag is 0.15.0 at d6ecc2c on Spe 3, 2015)
libipset 3ea7fe3(Jan 18, 2017) no tag(the newest tag is 1.1.1 at 848e8ac on Nov 16, 2010)

36 ↗(On Diff #35268)

Seems it supports --disable-documentation only, does not support --enable-documentation or something like enable.

AC_ARG_ENABLE([documentation],
  AS_HELP_STRING([--disable-documentation], [do not build documentation]),
  [disable_documentation=true],
  [disable_documentation=false])
AM_CONDITIONAL([ENABLE_DOCUMENTATION], [test x$disable_documentation = xfalse])

https://github.com/shadowsocks/shadowsocks-libev/blob/v3.1.0/configure.ac#L41

net/shadowsocks-libev/Makefile
31 ↗(On Diff #35268)

This option will enable/disable both man page and html doc. Not sure which option variable would be the best, DOCS, HTMLDOCS or ASCIIDOCS?

I found the DOC variable from the porter's handbook and referred the existing ports by searching find /usr/ports -name Makefile | xargs grep 'DOCS_BUILD_DEPENDS=.*asciidoc', so I choosed the DOCS.

Sounds good, you've convinced me. Go for it!

This revision is now accepted and ready to land.Nov 16 2017, 4:22 PM
This revision was automatically updated to reflect the committed changes.