Page MenuHomeFreeBSD

Update Neverwinter Nights ports
ClosedPublic

Authored by scf on Nov 5 2017, 2:43 AM.

Details

Summary

The URL's for the Neverwinter Nights data and client have moved again. This updates the port to use the new URL's for the Original and the Diamond editions of the game.

Since the available version of the Bink Player has changed and no archives of the old copy exist, the ability to play movies in the game is now experimental iff a newer version of the nwmovies.so hook is compiled and used. The binary for the hook is not currently provided, hence, it is experimental. I will be asking the maintainer of that hook to make a release for me to add to the port.

Test Plan
  • Have people review the diff, especially the configuration of MASTER_SITES in games/linux-nwnclient as it is non-conventional. This is the primary step as the rest appears to work well (for me :)).
  • Have people test downloading the files. If this is just part of the files due to them not owning the game, then that will have to do.
  • Unlikely, but find someone that owns the Original and/or Diamond editions to test the ports.

Note: The ports are scheduled for being removed on 2017-11-09, so I need to work quickly on this.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

I own/play nwn occasionally. I'm going to review/test this update.

The fetch/package stages work. I'll check if gameplay works when I get to my desktop.
It would be neat to be able to innoextract existing gog.com distfile for Diamond in nwndata.

linux-nwnclient/Makefile
12–17

You know, you can write:

${NWN_SITE_1}:ORIG,GOLD,HOTU
scf marked an inline comment as done.

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

linux-nwnclient/Makefile
8–19

Also, you should move both of those way way down, so that they are not in any pre-defined blocks. See Chapter 14. Order of Variables in Port Makefiles.

I was able to test this and it works.

I approve rescuing this port from expiration as-is at this point.
Additional cleanups can happen later.

This revision is now accepted and ready to land.Nov 8 2017, 2:25 PM
This revision was automatically updated to reflect the committed changes.