devel/liblas12: Fix build error on CURRENT
ClosedPublic
Actions

Authored by pizzamig on Oct 25 2017, 10:12 AM.

Details

Reviewers

lme
olivier

Commits

rP453408: devel/liblas12: Fix build error on CURRENT

Summary

devel/liblas12: Fix build error on CURRENT

PR\: 222424
Submitted by\: rhurlin@gwdg.de (maintainer)
Approved by\: lme (mentor)
Approved by\: olivier (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint's fine.
poudriere build on 10.3 10.4 11.0 11.1 on i386 amd64

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 12220
Build 12514: arc lint + arc unit

Event Timeline

pizzamig created this revision.Oct 25 2017, 10:12 AM

Harbormaster completed remote builds in B12220: Diff 34318.Oct 25 2017, 10:12 AM

Does this fall into the "Build fixes which cause a package to become compilable where it was previously failing" of the "Examples of changes which do not require a PORTREVISION bump" ?

Build error is only on FreeBSD CURRENT, I guess because of llvm 5.x Probably it was a warning on previous clang version.
The current port is already working on 10.x and 11.x, but I'm not sure that the patch fix only the C++ syntax or changes the binary as well. The new patch is now applied on every FreeBSD version.
A better solution, avoiding portrevision bump, could be to change the patch as extrapatch and apply it only if freebsd version >= 1200000.
I'll ask the maintainer.