Page MenuHomeFreeBSD

libva update to 2.0.0, shlib bump to dependent ports and fix of two dependent ports
ClosedPublic

Authored by madpilot on Oct 22 2017, 9:39 PM.
Referenced Files
F105130655: D12761.diff
Thu, Dec 12, 5:07 PM
Unknown Object (File)
Tue, Dec 10, 1:04 AM
Unknown Object (File)
Mon, Dec 9, 4:36 PM
Unknown Object (File)
Tue, Dec 3, 5:14 AM
Unknown Object (File)
Nov 2 2024, 11:32 PM
Unknown Object (File)
Oct 11 2024, 8:03 PM
Unknown Object (File)
Sep 26 2024, 9:54 PM
Unknown Object (File)
Sep 25 2024, 10:26 AM
Subscribers

Details

Summary

This patch updates libva and it's drivers to a new 2.0.0 version, which bumps the shlib version, breaks ABI and also has an API change.

The patch also simplifies the ports a little and fixes the DEBUG option when present in the ports I manage.

The multimedia/mpv and multimedia/gstreamer1-vaapi ports needed fixing to compile due to the API changes. The patches I used are taken from thee upstream repositories:

https://github.com/mpv-player/mpv/commit/2ecf240b1cd20875991a5b18efafbe799864ff7f
https://cgit.freedesktop.org/gstreamer/gstreamer-vaapi/commit/gst-libs/gst/vaapi/gstvaapiutils.c?id=777bba473e3ed1c7b8b7f7f0322892851c70dfd9

If I forgot some dependent port please report that to me so I can bump PORTREVISION there too.

Test Plan

I have tested all the ports I'm touching in my poudriere on head, 11.1 and 10.4 with success.

I have tested the libva port and drivers using vainfo with vlc on my PCs checking hardware features are actually used.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Updated patch.

First patch was missing one patch file in gstreamer1-vaapi port.

This revision is now accepted and ready to land.Oct 22 2017, 9:45 PM

LGTM

Thanks for the heads up!

multimedia/libva-utils/Makefile
32–33

This is really, really wrong.

If one wants to enable debug, one can set either of:

OPTIONS_SET= DEBUG
OPTIONS_SET_FORCE= DEBUG

But don't change OPTIONS_DEFAULT from external variables.

madpilot added inline comments.
multimedia/libva-utils/Makefile
32–33

I can see. I'll remove this stanza.

Thanks.

Removed wrong stanza modifying OPTIONS_DEFAULTS depending on external variable.

Update diff to latest ports tree snapshot.

Update patch to ports tree r453973

This revision was not accepted when it landed; it landed in state Needs Review.Dec 12 2017, 9:30 PM
Closed by commit rP456184: - Update libva to 2.0.0 (authored by madpilot). · Explain Why
This revision was automatically updated to reflect the committed changes.