Page MenuHomeFreeBSD

Move clear_unrhdr to tmpfs_free_tmp.
ClosedPublic

Authored by mjoras on Oct 20 2017, 10:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 28 2024, 3:02 AM
Unknown Object (File)
Oct 21 2024, 11:32 PM
Unknown Object (File)
Oct 19 2024, 6:23 PM
Unknown Object (File)
Oct 1 2024, 9:57 PM
Unknown Object (File)
Sep 27 2024, 4:56 PM
Unknown Object (File)
Sep 24 2024, 5:34 AM
Unknown Object (File)
Sep 6 2024, 12:24 AM
Unknown Object (File)
Aug 22 2024, 5:34 PM
Subscribers

Details

Summary

Clearing the unr in tmpfs_unmount is not correct. In the case of
multiple references to the tmpfs mount (e.g. when there are lookup
threads using it) it will not be the one to finish tmpfs_free_tmp. In
those cases tmpfs_free_node_locked will be the final one to execute
tmpfs_free_tmp, and until then the unr must be valid.

Test Plan

This was originally reported and reproduced by pho using his stress2/misc/
tmpfs* tests. It is trivially reproduced with e.g. tmpfs13.sh, and the
problem does not reproduce after the change. pho offered to run some more
stress tests on the change. All of his tmpfs tests passed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable