Page MenuHomeFreeBSD

Avoid the nbp lookup in the final loop iteration in flushbuflist()
ClosedPublic

Authored by markj on Oct 19 2017, 4:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 10, 11:10 PM
Unknown Object (File)
Sat, May 9, 7:43 PM
Unknown Object (File)
Sat, May 9, 6:43 PM
Unknown Object (File)
Sat, May 9, 6:02 PM
Unknown Object (File)
Sat, May 9, 12:10 PM
Unknown Object (File)
Fri, May 8, 6:12 PM
Unknown Object (File)
Apr 5 2026, 7:07 PM
Unknown Object (File)
Apr 3 2026, 10:54 PM
Subscribers
None

Details

Summary

At the end of the final iteration, we have lblkno = xflags = 0 and thus
set nbp = gbincore(bo, 0). The xflags test will fail and cause the loop
to end, but this seems like a fragile and non-obvious mechanism. Modify
the test so that we break if nbp == NULL at the beginning of the loop.

No functional change intended; we just avoid an unnecessary lookup once
per call.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Avoid the inline assignment
This revision is now accepted and ready to land.Oct 19 2017, 5:24 PM
This revision was automatically updated to reflect the committed changes.