Add PowerPC64 function descriptor support for dt_link.c
ClosedPublic
Actions

Authored by jhibbits on Dec 5 2014, 2:19 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 20, 3:04 AM

	Unknown Object (File)
	Tue, Apr 14, 10:54 AM

	Unknown Object (File)
	Thu, Apr 9, 6:52 PM

	Unknown Object (File)
	Tue, Apr 7, 11:49 PM

	Unknown Object (File)
	Sun, Apr 5, 9:43 PM

	Unknown Object (File)
	Sun, Apr 5, 10:44 AM

	Unknown Object (File)
	Fri, Mar 27, 12:24 AM

	Unknown Object (File)
	Wed, Mar 25, 1:42 AM

View All 83 Files

Subscribers

markj

Details

Reviewers

markj

Group Reviewers

DTrace

Summary

PowerPC64 uses function descriptors in a section .opd, exporting the descriptors
to the symbol table. This adds support for these into dt_link.c so that dtrace
USDT probes can be compiled.

Test Plan

Tested only on powerpc64. No regression testing has been performed, so I want
someone with x86 hardware to regression test this.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

jhibbits updated this revision to Diff 2639.Dec 5 2014, 2:19 AM

jhibbits retitled this revision from to Add PowerPC64 function descriptor support for dt_link.c.

jhibbits updated this object.

jhibbits edited the test plan for this revision. (Show Details)

jhibbits added a reviewer: DTrace.

This looks good to me; I'll be able to test it on x86 over the weekend.

cddl/contrib/opensolaris/lib/libdtrace/common/dt_link.c
688	Don't you still need to keep the powerpc32 case?

Seems to work properly on amd64. Thanks!

cddl/contrib/opensolaris/lib/libdtrace/common/dt_link.c
688	Answering my own question: no, because this function handles only 64-bit architectures.

This revision is now accepted and ready to land.Dec 26 2014, 7:11 PM

Committed in r276326.

Revision Contents
Changeset List

Path

Size

cddl/

contrib/

opensolaris/

lib/

libdtrace/

common/

dt_link.c

39 lines

Diff 2639

View Options

cddl/contrib/opensolaris/lib/libdtrace/common/dt_link.c

Add PowerPC64 function descriptor support for dt_link.cClosedPublicActions