Paths

Table of Contentst

Differential D12640

libc: allow posix_fallocate in capability mode
ClosedPublic
Actions

Authored by emaste on Oct 11 2017, 7:46 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Sep 8, 12:33 PM

	Unknown Object (File)
	Sat, Sep 5, 3:05 PM

	Unknown Object (File)
	Sat, Sep 5, 12:56 PM

	Unknown Object (File)
	Sat, Sep 5, 7:31 AM

	Unknown Object (File)
	Sat, Sep 5, 1:43 AM

	Unknown Object (File)
	Fri, Sep 4, 1:03 PM

	Unknown Object (File)
	Thu, Sep 3, 9:17 AM

	Unknown Object (File)
	Thu, Sep 3, 12:45 AM

Subscribers

None

Details

Reviewers

Group Reviewers

Commits

rS324560: allow posix_fallocate in capability mode

Summary

posix_fallocate is logically equivalent to writing zero blocks to the desired file size and there is no reason to prevent calling it in capability mode. posix_fallocate already checked for the CAP_WRITE right, so we merely need to list it in capabilities.conf.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste created this revision.Oct 11 2017, 7:46 PM

Per discussion on the recent capsicum call, posix_fallocate could require CAP_PWRITE (aka CAP_WRITE | CAP_SEEK) instead of just CAP_WRITE.

Require CAP_PWRITE (CAP_WRITE | CAP_SEEK) for posix_fallocate.

allanjude accepted this revision.Oct 12 2017, 2:04 AM

This revision is now accepted and ready to land.Oct 12 2017, 2:04 AM

Closed by commit rS324560: allow posix_fallocate in capability mode (authored by emaste). · Explain WhyOct 12 2017, 3:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

lib/

libc/

sys/

posix_fallocate.2

6 lines

sys/

kern/

capabilities.conf

1 line

2 lines

Diff 33917

head/lib/libc/sys/posix_fallocate.2

Loading...

head/sys/kern/capabilities.conf

Loading...

head/sys/kern/vfs_syscalls.c

Loading...