Differential D12407

linsysfs(5): Fix two unrelated issues
ClosedPublic
Actions

Authored by cem on Sep 18 2017, 4:13 PM.

Details

Reviewers

• hselasky

Commits

rS323710: linsysfs(5): Fix two unrelated issues

Summary

Swap the order of device_get_ivars with device_get_devclass and devclass

name validation. This bug was introduced in r323692.

Error check device_get_children and free the returned list. This bug was

introduced in the original linsysfs commit.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem created this revision.Sep 18 2017, 4:13 PM

Harbormaster completed remote builds in B11621: Diff 33190.Sep 18 2017, 4:13 PM

Will go ahead and commit unreviewed to fix the issue reported by Oleg V. Nauman since it seems like you've gone offline. Both fixes are straightforward.

• hselasky added inline comments.Sep 18 2017, 5:05 PM

sys/compat/linsysfs/linsysfs.c
357 ↗	(On Diff #33190)	else name = NULL; The code above might have dirtied this variable.

Initialize name

Harbormaster completed remote builds in B11623: Diff 33199.Sep 18 2017, 5:07 PM

cem marked an inline comment as done.Sep 18 2017, 5:07 PM

Looks good to me.

This revision is now accepted and ready to land.Sep 18 2017, 5:11 PM

Closed by commit rS323710: linsysfs(5): Fix two unrelated issues (authored by cem). · Explain WhySep 18 2017, 5:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

compat/

linsysfs/

linsysfs.c

29 lines

Diff 33200

View Options

head/sys/compat/linsysfs/linsysfs.c

linsysfs(5): Fix two unrelated issuesClosedPublicActions