Page MenuHomeFreeBSD

x11-themes/sddm-freebsd-black-theme: New Port
AbandonedPublic

Authored by rigoletto on Sep 15 2017, 1:45 AM.
Tags
Referenced Files
Unknown Object (File)
Dec 20 2023, 7:01 AM
Unknown Object (File)
Nov 25 2023, 6:41 AM
Unknown Object (File)
Nov 21 2023, 11:51 PM
Unknown Object (File)
Nov 21 2023, 1:16 PM
Unknown Object (File)
Nov 15 2023, 5:05 PM
Unknown Object (File)
Nov 15 2023, 4:07 PM
Unknown Object (File)
Nov 10 2023, 6:34 AM
Unknown Object (File)
Nov 7 2023, 8:16 PM
Subscribers

Details

Reviewers
tcberner
Summary

Simple SDDM theme inspired on the FBSD SLiM theme.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Removing the x11-fonts/ohsnap update from the diff, what was accidentally included.

x11-themes/sddm-freebsd-black-theme/Makefile
21

Why += ?

31

Never use both do- and post-, put everything in do-.

x11-themes/sddm-freebsd-black-theme/pkg-descr
2

pkg-descr should always be longer than COMMENT, a few lines at least.

x11-themes/sddm-freebsd-black-theme/Makefile
27

Couldn't you add something ala

Additional find arguments can be passed via the third argument to COPYTREE_* macros. For example, to install all files from the first example except Makefiles, one can use these commands.

and get rid of the rm?

Submitting a new diff.

x11-themes/sddm-freebsd-black-theme/Makefile
27

I could not find a way to use that feature to avoid a directory but just its files.

So, I think I found another solution: I will revert back to v1.0, what does not have the "doc" directory, and the v1.0.1 will cease its existence.

The only difference between both versions is the doc directory.

rigoletto marked an inline comment as done.
  • I downgraded from the v1.0.1 (what is dead now) to v1.0 since I could not find a way to use the "COPYTREE" builtin find feature to avoid directories but just its files. The v1.0 does not have the doc directory.
  • Fixed the others requests. [I think]

Thanks!

rigoletto marked an inline comment as done.
rigoletto set the repository for this revision to rP FreeBSD ports repository.

Updating "LICENSE_FILE" to reflect the current absence of the doc folder.

I think I was doing it wrong just bringing the diff of the later modified files instead of everything related.

I am "fixing" it now.

Sorry.

x11-themes/sddm-freebsd-black-theme/Makefile
23–24

Rename DOC_FILES to PORTDOCS.

x11-themes/sddm-freebsd-black-theme/pkg-plist
1–4

Remove this.