Page MenuHomeFreeBSD
Differential D12207

sysutils/py-google-compute-engine: add missing google_ip_forwarding_daemon script in USE_RC_SUBR
ClosedPublic
Actions

Authored by ultima on Sep 1 2017, 5:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 20, 3:26 AM
Unknown Object (File)
Tue, Oct 14, 11:47 AM
Unknown Object (File)
Mon, Oct 6, 3:14 PM
Unknown Object (File)
Thu, Oct 2, 4:23 AM
Unknown Object (File)
Wed, Oct 1, 12:32 PM
Unknown Object (File)
Wed, Oct 1, 3:47 AM
Unknown Object (File)
Tue, Sep 30, 8:48 PM
Unknown Object (File)
Tue, Sep 30, 10:47 AM
View All 100 Files
Subscribers
mat

Details

Reviewers
lifanov
matthew
Commits
rP449170: Add missing rc script, this should fix possible issues with ip forwarding
Summary

Add missing rc script, this should fix possible issues with ip forwarding

PR\: 221917
Submitted by\: Helen Koike (maintainer)
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
0 fatal errors and 2 warnings found.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ultima created this revision.Sep 1 2017, 5:35 PM
Herald added a subscriber: mat. · View Herald TranscriptSep 1 2017, 5:35 PM
Harbormaster completed remote builds in B11332: Diff 32594.Sep 1 2017, 5:35 PM
matthew accepted this revision.Sep 2 2017, 6:02 PM

It should be sysutils/*py*-google-compute-engine in the review title.

On the whole though,

lgtm

This revision is now accepted and ready to land.Sep 2 2017, 6:02 PM
ultima retitled this revision from sysutils/google-compute-engine: add missing google_ip_forwarding_daemon script in USE_RC_SUBR to sysutils/py-google-compute-engine: add missing google_ip_forwarding_daemon script in USE_RC_SUBR.Sep 3 2017, 2:27 AM
Closed by commit rP449170: Add missing rc script, this should fix possible issues with ip forwarding (authored by ultima). · Explain WhySep 3 2017, 2:31 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sysutils/
py-google-compute-engine/
2 lines

Diff 32616

View Options

head/sysutils/py-google-compute-engine/Makefile

Loading...