Page MenuHomeFreeBSD
Differential D12135

Add devel/py-logfury.
ClosedPublic
Actions

Authored by gordon on Aug 27 2017, 5:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 27, 11:46 PM
Unknown Object (File)
Wed, Nov 26, 6:13 AM
Unknown Object (File)
Tue, Nov 25, 10:29 PM
Unknown Object (File)
Tue, Nov 25, 12:47 AM
Unknown Object (File)
Mon, Nov 24, 8:32 AM
Unknown Object (File)
Wed, Nov 19, 4:19 AM
Unknown Object (File)
Tue, Nov 18, 1:57 AM
Unknown Object (File)
Mon, Nov 17, 6:17 PM
View All Files
Subscribers
ler
mat

Details

Reviewers
mat
ler
Commits
rP449267: New port: devel/py-logfury
Summary

Add devel/py-logfury, a toolkit for responsible, low-boilerplate logging of library method calls.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 11254
Build 11628: arc lint + arc unit

Event Timeline

gordon created this revision.Aug 27 2017, 5:08 PM
Herald added a subscriber: mat. · View Herald TranscriptAug 27 2017, 5:08 PM
gordon added a reviewer: mat.Aug 27 2017, 5:09 PM

Mat, can you please take a look at this? I haven't added a new port in ages and wanted a second pair of eyes before committing. It passed portlint -CN without issue.

ler accepted this revision.Aug 27 2017, 5:36 PM
ler added a subscriber: ler.

Looks reasonable to me.

This revision is now accepted and ready to land.Aug 27 2017, 5:36 PM
gordon updated this revision to Diff 32425.Aug 27 2017, 5:40 PM
gordon edited edge metadata.

Clarify comment.

This revision now requires review to proceed.Aug 27 2017, 5:40 PM
Harbormaster completed remote builds in B11255: Diff 32425.Aug 27 2017, 5:40 PM
gordon updated this revision to Diff 32426.Aug 27 2017, 5:41 PM

Argh. I didn't realize it would delete the other files.

Harbormaster completed remote builds in B11256: Diff 32426.Aug 27 2017, 5:41 PM
mat requested changes to this revision.Aug 28 2017, 10:36 AM
mat added inline comments.
devel/py-logfury/Makefile
16

There has not been a python 2.6 in the ports tree for three and a half years. 2.7+ here.

22–23

This should be between the license block and the use* block. See Chapter 14. Order of Variables in Port Makefiles.

Also, replace += with =.

This revision now requires changes to proceed.Aug 28 2017, 10:36 AM
gordon updated this revision to Diff 32472.Aug 29 2017, 3:19 AM
gordon edited edge metadata.

Update for mat's feedback.

Harbormaster completed remote builds in B11276: Diff 32472.Aug 29 2017, 3:19 AM
Closed by commit rP449267: New port: devel/py-logfury (authored by gordon). · Explain WhySep 5 2017, 4:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
devel/
1 line
24 lines
3 lines
4 lines

Diff 32424

View Options

devel/Makefile

Loading...
View Options

devel/py-logfury/

Loading...
View Options

devel/py-logfury/Makefile

Loading...
View Options

devel/py-logfury/distinfo

Loading...
View Options

devel/py-logfury/pkg-descr

Loading...