Page MenuHomeFreeBSD

Add devel/py-logfury.
ClosedPublic

Authored by gordon on Aug 27 2017, 5:08 PM.

Details

Summary

Add devel/py-logfury, a toolkit for responsible, low-boilerplate logging of library method calls.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Mat, can you please take a look at this? I haven't added a new port in ages and wanted a second pair of eyes before committing. It passed portlint -CN without issue.

ler added a subscriber: ler.

Looks reasonable to me.

This revision is now accepted and ready to land.Aug 27 2017, 5:36 PM
gordon edited edge metadata.

Clarify comment.

This revision now requires review to proceed.Aug 27 2017, 5:40 PM

Argh. I didn't realize it would delete the other files.

mat requested changes to this revision.Aug 28 2017, 10:36 AM
mat added inline comments.
devel/py-logfury/Makefile
15 ↗(On Diff #32426)

There has not been a python 2.6 in the ports tree for three and a half years. 2.7+ here.

21–22 ↗(On Diff #32426)

This should be between the license block and the use* block. See Chapter 14. Order of Variables in Port Makefiles.

Also, replace += with =.

This revision now requires changes to proceed.Aug 28 2017, 10:36 AM
gordon edited edge metadata.

Update for mat's feedback.

This revision was automatically updated to reflect the committed changes.