[MAINTAINER UPDATE] databases/mongodb34-rocks: Unbreak and update to 3.4.6

[ultima]

Summary

• Updated to 3.4.6
• Cleanup Makefile
• Added CONFLICTS to solves compatibility with the version of databases/rocksdb

PR\:
Submitted by\:
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: use of DISTFILES with single file discouraged. distribution filename should be set by DISTNAME and EXTRACT_SUFX.
WARN: Makefile: "LIB_DEPENDS" has to appear earlier.
WARN: Makefile: "TEST_DEPENDS" has to appear earlier.
WARN: Makefile: do not use DISTFILES and DISTNAME to control WRKSRC. how about "WRKSRC=${WRKDIR}/mongodb-src-${DISTVERSIONPREFIX}${PORTVERSION}"?
0 fatal errors and 5 warnings found.

poudriere:
103i386: is only for amd64, while you are running i386 (reason: "Only supported on amd64 (i386 deprecated in v3)")
103amd64
110i386: is only for amd64, while you are running i386 (reason: "Only supported on amd64 (i386 deprecated in v3)")
110amd64
12i386: is only for amd64, while you are running i386 (reason: "Only supported on amd64 (i386 deprecated in v3)")
12amd64

[ultima]

databases/mongodb34-rocks/Makefile

42 ↗

(On Diff #32076)

I'm pretty sure this wasn't doing anything, so removed it. Wanted to make a note here regardless in case I am wrong.

74 ↗

(On Diff #32076)

Not positive, but the pre.mk/post.mk _may_ be removable. Want verification before I do so because not sure why they are defined in the first place.

[matthew]

Yeah -- taking out bsd.port.{pre|post}.mk works fine.

I you can apply that, then approved to commit.

databases/mongodb34-rocks/Makefile

74 ↗

(On Diff #32076)

Yes, you should be able to remove it. If everything is using OPTIONS helpers and there
are no tests of the form:

.if ${VAR:Msomething}

or

.if ${VAR} == something

then you're safe to just .include <bsd.port.mk> at the end of the Makefile. Besides, it's usually pretty obvious if you get this wrong. Things will be pretty definitively broken when you try a test build.

[ultima]

databases/mongodb34-rocks/Makefile

74 ↗

(On Diff #32076)

Okay, that is what I thought. Still a little skeptical at times when I see this used.