[NEW PORT] security/highwayhash: Fast strong hash functions: SipHash/HighwayHash

[ultima]

Summary

Strong (well-distributed and unpredictable) hashes:

• Portable implementation of SipHash
• HighwayHash, a 5x faster SIMD hash with security claims

WWW: https://github.com/google/highwayhash

PR\: 219232
Submitted by\: Yuri Victorovich (maintainer)
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
looks fine.

poudriere:
103i386: is only for amd64 arm64 powerpc powerpc64, while you are running i386 (reason: Assembly is implemented only for specific architectures in highwayhash/tsc_timer.h)
103amd64
110i386: is only for amd64 arm64 powerpc powerpc64, while you are running i386 (reason: Assembly is implemented only for specific architectures in highwayhash/tsc_timer.h)
110amd64
12i386: is only for amd64 arm64 powerpc powerpc64, while you are running i386 (reason: Assembly is implemented only for specific architectures in highwayhash/tsc_timer.h)
12amd64

[ultima]

security/highwayhash/Makefile

27–33 ↗

(On Diff #31976)

This is a bit messy, the maintainer has requested upstream to fix.

[matthew]

security/highwayhash/Makefile

27–33 ↗

(On Diff #31976)

It's good when port maintainers upstream FreeBSD related changes -- here it would be good to get the content from patch-highwayhash_os__specific.cc upstreamed as well. If a change has been submitted upstream, mentioning that in the commit message is a good thing to do.

However, none of that should hold up getting the update into the tree. Showing that thousands of people are already using a patch is very persuasive to the upstream projects.

[ultima]

• Added comment and link to upstream issue

[matthew]