Page MenuHomeFreeBSD

[NEW PORT] security/highwayhash: Fast strong hash functions: SipHash/HighwayHash
ClosedPublic

Authored by ultima on Aug 12 2017, 4:32 AM.

Details

Summary

Strong (well-distributed and unpredictable) hashes:

  • Portable implementation of SipHash
  • HighwayHash, a 5x faster SIMD hash with security claims

WWW: https://github.com/google/highwayhash

PR\: 219232
Submitted by\: Yuri Victorovich (maintainer)
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
looks fine.

poudriere:
103i386: is only for amd64 arm64 powerpc powerpc64, while you are running i386 (reason: Assembly is implemented only for specific architectures in highwayhash/tsc_timer.h)
103amd64
110i386: is only for amd64 arm64 powerpc powerpc64, while you are running i386 (reason: Assembly is implemented only for specific architectures in highwayhash/tsc_timer.h)
110amd64
12i386: is only for amd64 arm64 powerpc powerpc64, while you are running i386 (reason: Assembly is implemented only for specific architectures in highwayhash/tsc_timer.h)
12amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ultima created this revision.Aug 12 2017, 4:32 AM
ultima added inline comments.Aug 12 2017, 4:37 AM
security/highwayhash/Makefile
27–33 ↗(On Diff #31976)

This is a bit messy, the maintainer has requested upstream to fix.

matthew added inline comments.Aug 12 2017, 9:19 AM
security/highwayhash/Makefile
27–33 ↗(On Diff #31976)

It's good when port maintainers upstream FreeBSD related changes -- here it would be good to get the content from patch-highwayhash_os__specific.cc upstreamed as well. If a change has been submitted upstream, mentioning that in the commit message is a good thing to do.

However, none of that should hold up getting the update into the tree. Showing that thousands of people are already using a patch is very persuasive to the upstream projects.

ultima updated this revision to Diff 31990.Aug 12 2017, 5:32 PM
  • Added comment and link to upstream issue
This revision is now accepted and ready to land.Aug 13 2017, 12:37 PM
This revision was automatically updated to reflect the committed changes.