Preserve mount flags in smbfs.
ClosedPublic
Actions

Authored by trasz on Nov 19 2014, 9:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 27, 10:03 PM

	Unknown Object (File)
	Tue, Dec 10, 4:02 PM

	Unknown Object (File)
	Oct 17 2024, 9:11 PM

	Unknown Object (File)
	Oct 17 2024, 8:59 PM

	Unknown Object (File)
	Sep 26 2024, 12:46 PM

	Unknown Object (File)
	Sep 26 2024, 10:06 AM

	Unknown Object (File)
	Sep 24 2024, 5:16 PM

	Unknown Object (File)
	Sep 23 2024, 5:51 PM

View All 81 Files

Subscribers

None

Details

Reviewers

kib

Commits

rS274784: Fix smbfs to not zero out statfs f_flags field. Previously, this

Summary

Fix smbfs to not zero out statfs f_flags field. Previously, this
made getmntinfo() return empty flags for smbfs filesystems when
called with MNT_WAIT. It's not visible with mount(8), since it uses
MNT_NOWAIT, but broke autounmount(8) operation.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

trasz updated this revision to Diff 2466.Nov 19 2014, 9:01 PM

trasz retitled this revision from to Preserve mount flags in smbfs..

trasz updated this object.

trasz edited the test plan for this revision. (Show Details)

trasz added a reviewer: kib.Nov 19 2014, 9:02 PM

Unconditional zeroing of f_flags seems to be present from the initial commit of smbfs.
I have no idea why it was done this way.

I do not see anything wrong with the patch, but I equally know nothing about smbfs.

This revision is now accepted and ready to land.Nov 20 2014, 6:29 PM

Closed by commit rS274784 (authored by @trasz).

Revision Contents
Changeset List

Path

Size

head/

sys/

fs/

smbfs/

smbfs_vfsops.c

2 lines

Diff 2488

View Options

head/sys/fs/smbfs/smbfs_vfsops.c

Preserve mount flags in smbfs.ClosedPublicActions