net/guacamole-server: Updated to 0.9.13

[ultima]

Summary

• Updated to 0.9.13
• Sorted USES section to better comply with PHB
• Changed custom etc dir to ETCDIR, added note in UPDATING
• Sorted and enhanced option section
• Added a guacd sample file
• Added NLS knob

Changelog: https://guacamole.incubator.apache.org/releases/0.9.13-incubating

Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 1 warning found.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

[ultima]

Sorted targets

[matthew]

UPDATING

13 ↗

(On Diff #31462)

Typo: has changed

net/guacamole-server/Makefile

49 ↗

(On Diff #31462)

In general, it is fine to keep the variables pertaining to each different option -- options helpers, option descriptions, etc -- grouped by the leading option name, as they were previously, although putting a blank line between the groups for each option is a good idea.

You are right to drop the ?= from all the FOO_DESC settings though.

[ultima]

• Enabled spell checking by default in vim
• Fixed typo

[ultima]

net/guacamole-server/Makefile

49 ↗

(On Diff #31462)

This was actually changed because this is how chapter 14.9[1] in phb describes the order of how options are defined. I'll keep the alternative approach in mind for the future.

PHB seems to be getting a lot of attention lately. The chapter numbering has changed.

[1] If the port uses the options framework, define OPTIONS_DEFINE and OPTIONS_DEFAULT first, then the other OPTIONS_* variables first, then the *_DESC descriptions, then the options helpers. Try and sort all of those alphabetically.

[matthew]

net/guacamole-server/Makefile

49 ↗

(On Diff #31462)

I didn't know the PHB said that. No problem then.

[mat]

net/guacamole-server/Makefile

49 ↗

(On Diff #31462)

When I first wrote the Makefile order thing, I did not know where to put it, so I added it to the Makefile example chapter, but I decided to move it to its own chapter this week, sorry about moving stuff around, I try to not do it in the first place :-)