Page MenuHomeFreeBSD

Use db_printsym() instead of our own in backtraces
ClosedPublic

Authored by jhibbits on Nov 15 2014, 9:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 12:09 AM
Unknown Object (File)
Mar 31 2017, 3:17 AM
Unknown Object (File)
Nov 17 2016, 2:13 AM
Unknown Object (File)
Sep 15 2016, 1:14 PM
Unknown Object (File)
Sep 9 2016, 12:57 AM
Unknown Object (File)
Aug 27 2016, 7:14 AM
Unknown Object (File)
Aug 19 2016, 11:48 AM
Unknown Object (File)
Jun 20 2016, 8:23 AM
Subscribers
None

Details

Reviewers
nwhitehorn
Group Reviewers
PowerPC
Summary

Currently if there are problems finding a symbol, backtrace ends up printing
something like:

0xdeadbeef: at +0x12345

Which is pretty useless. This on its own should be fixed (retrieving symbols),
but aside from that, using db_printsym() is a better solution anyway. If it
can't find a valid symbol it prints the actual address, and it has the added
benefit that if it can find the symbol, it might be able to print the file and
line as well.

Test Plan

Tested on my G4 PowerBook

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

jhibbits retitled this revision from to Use db_printsym() instead of our own in backtraces.
jhibbits updated this object.
jhibbits edited the test plan for this revision. (Show Details)
jhibbits added reviewers: PowerPC, nwhitehorn.
nwhitehorn edited edge metadata.

This looks great to me!

This revision is now accepted and ready to land.Nov 20 2014, 3:44 AM