security/hardening-check: Change MASTER_SITES to DEBIAN pool and remove SHEBANG_LANG

[ultima]

Summary

• Changed MASTER_SITES to DEBIAN pool
• Removed SHEBANG_LANG, shebandfix already includes this for perl

PR\: 220569
Reported by\: matt
Reviewed by\: lifanov (mentor), matthew (mentor), Jov <[e-mail]> (maintainer)
Approved by\: lifanov (mentor), matthew (mentor), Jov <[e-mail]> (maintainer)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or PKGNAMESUFFIX.
0 fatal errors and 2 warnings found.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

[lifanov]

Approved!

[mat]

head/security/hardening-check/Makefile

6–8

This is:

​MASTER_SITES=        DEBIAN/pool/main/h/hardening-wrapper

Never use MASTER_SITE_SUBDIR, I spent enough time removing all occurrences I could, do not add them. (Side note, the porter's handbook tells you exactly that too)

[ultima]

head/security/hardening-check/Makefile

6–8

Sorry about that, I didn't realize it was deprecated.

[mat]

head/security/hardening-check/Makefile

6–8

Mmmm, deprecated is maybe a bit too strong, discourraged is more like it. Most of the time, you do not need to use it, and should refrain from.
The most frequent use case is when fetching from CPAN.
There may also be some rare cases where using it is makes it simpler and shorter, but those cases few.

[ultima]

head/security/hardening-check/Makefile

6–8

-MASTER_SITES= DEBIAN
-MASTER_SITE_SUBDIR= pool/main/h/hardening-wrapper
+MASTER_SITES= DEBIAN/pool/main/h/hardening-wrapper

I need approval to commit.

[matthew]

Approved.