devel/google-perftools: Update to 2.6

[ultima]

Summary

• Updated to 2.6
• Moved LIB_DEPENDS, BROKEN_* Comes before *_DEPENDS
• Moved USES, comes before USE_*
• Added gmake to USES
• New options, PAGE and ALIGN, Default PAGE8k ALIGN16

Changelog: https://github.com/gperftools/gperftools/releases/tag/gperftools-2.6

PR\: 220519
Sumitted by\: Yuri Victorovich <[e-mail]> (maintainer)
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or PKGNAMESUFFIX.
WARN: Makefile: "LIB_DEPENDS" has to appear earlier.
0 fatal errors and 3 warnings found.
False positives.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

[matthew]

Compiles fine. Approved, but remember to cite your authority for reordering bits of the Makefile (resulting in a new portlint warning)
in your commit message. Or else leave the LIB_DEPENDS and USES lines in their original locations.

devel/google-perftools/Makefile

20 ↗

(On Diff #30553)

Given that portlint complains that LIB_DEPENDS has to appear earlier -- where are you getting the requirement for BROKEN_* before *_DEPENDS ordering from? If it's the Porter's Handbook, that's fine, but you should mention that in the commit message. If it's somewhere else then I'd probably go with the ordering suggested by portlint.

26 ↗

(On Diff #30553)

Again, you're going to need to justify moving these lines around. Following the PH would be sufficient.

It's unfortunate that this ordering of USES and USE_FOO is not something that portlint will complain about or you could just say you were following that.

IIRC there were some recent patches to portlint to do with this sort of stuff. I wonder if they got committed?

[ultima]

I'll be sure to make my commit log more clear on these changes and why.

devel/google-perftools/Makefile

20 ↗

(On Diff #30553)

The Porters Handbook. The BROKEN_* are 13.1.5. The *_DEPENDS follow at 13.1.6 going in order of the Makefile format.

26 ↗

(On Diff #30553)

PH again, USES should come before USE_* 13.1.7. This section should provide a bit more details on other configuration variables like GNU_CONFIGURE. Following the chapter these variables should be placed under the option section. However the sample Makefile has this above the USES which violates 13.1.7. We should modified this section block to clarify these points. I have no problem adding it to the docs, but don't feel qualified make this decision.