security/py-{acme,certbot}: Update to 0.16.0 Common: - Update PORTVERSION and distinfo checksum (0.16.0) Changelog: https://github.com/certbot/certbot/blob/master/CHANGELOG.md#0160---2017-07-05 Reviewed_by: koobs (maintainer, py-certbot) Approved by: koobs (maintainer, py-certbot) Differential_Revision: D11517
Details
Details
- portlint -ac output looks fine.
- poudriere testport builds fine on 10.3/i386, 10.3/amd64, 11.0/i386, 11.0/amd64, 12.0/i386 and 12.0/amd64.
- make test has passed all tests fine.
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Can you add an explanation of the requests version reversion to the commit log message?
Comment Actions
Upstream bumped requests requirement to >=2.10 to fix issue 3804
An unexpected error occurred: TypeError: __str__ returned non-string (type Error)
See https://github.com/certbot/certbot/issues/3804 for further details.
Comment Actions
I noticed that I can undo the py-requests requirement version because we have already py-requests version 2.17.3 in the ports tree. Now it makes sense to discard the change from acme/setup.py.
Comment Actions
Kubilay,
One more thing: If you're interested to maintain py-acme, please let me know.
Comment Actions
@cpm LGTM. Re common maintainer, the existing workflow seems to be working well for now, no? :)