Page MenuHomeFreeBSD

net/go-cs: update to 0.7net/go-cs: update to 0.7
ClosedPublic

Authored by ultima on Jul 6 2017, 5:46 AM.

Details

Summary
  • Updated to 0.7
  • Fixed pkg-descr
  • Added USES= go
    • Fix error in cs.1

PR\: 220497
Sumitted by\: Andy Kosela <akosela@andykosela.com> (maintainer)
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 1 warning found.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ultima created this revision.Jul 6 2017, 5:46 AM
ultima edited the summary of this revision. (Show Details)Jul 6 2017, 5:47 AM
lifanov edited edge metadata.Jul 6 2017, 3:22 PM

You should replace all of this with USES=go stuff:

GO_CMD=                ${LOCALBASE}/bin/go
GO_ARGS=        build -ldflags "${STRIP}"

do-build:
        (cd ${WRKSRC}/cs && ${GO_CMD} ${GO_ARGS} cs.go)
lifanov requested changes to this revision.Jul 6 2017, 3:22 PM
This revision now requires changes to proceed.Jul 6 2017, 3:22 PM
ultima edited edge metadata.Jul 6 2017, 6:55 PM
ultima updated this revision to Diff 30504.

This has a very similar issue to gohugo. do-build and do-install are in different locations than the go.mk uses. Modified the do-build to set env varaibles as I did with gohugo.

lifanov requested changes to this revision.EditedJul 6 2017, 7:38 PM

You can mess with these by setting GO_PKGNAME and GO_TARGET.

Try this:

GO_TARGET=	${GO_PKGNAME}/cs

do-install:
	${INSTALL_PROGRAM} ${WRKDIR}/bin/cs ${STAGEDIR}${PREFIX}/bin
	${INSTALL_MAN} ${WRKSRC}/cs.1 ${STAGEDIR}${MAN1PREFIX}/man/man1

This way you don't need GO_CMD, GO_ARGS, or do-build.

This revision now requires changes to proceed.Jul 6 2017, 7:38 PM
ultima edited edge metadata.Jul 6 2017, 9:20 PM
ultima updated this revision to Diff 30513.

This looks much cleaner. =]

lifanov accepted this revision.Jul 7 2017, 12:45 AM

Looks great!

This revision is now accepted and ready to land.Jul 7 2017, 12:45 AM
This revision was automatically updated to reflect the committed changes.