Page MenuHomeFreeBSD

net-mgmt/ccnet-client: 6.0.6 fails to build with LibreSSL
ClosedPublic

Authored by ultima on Jul 3 2017, 2:43 AM.

Details

Summary
  • Add patch to fix build for libressl
  • Removed --enable-ldap, not a valid configure arg

PR\: 219605
Sumitted by\: Jens K. Loewe <mozilla@tuxproject.de>
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support.
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
0 fatal errors and 3 warnings found.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

net-mgmt/ccnet-client/Makefile
32 ↗(On Diff #30333)

Is there a reason why this section moved as part of the change?

net-mgmt/ccnet-client/Makefile
32 ↗(On Diff #30333)

Ah yeah, I have been trying to follow [1] as best as possible, and I noticed that it was out of order.

[1] https://www.freebsd.org/doc/en/books/porters-handbook/porting-samplem.html#porting-samplem-order

This revision is now accepted and ready to land.Jul 6 2017, 1:31 AM
This revision was automatically updated to reflect the committed changes.
head/net-mgmt/ccnet-client/Makefile
6

Why bump PORTREVISION ?

head/net-mgmt/ccnet-client/Makefile
6

Changing patch would require regenerating pkg. I guess it isn't really needed because it would fail to build on libressl before anyway.

head/net-mgmt/ccnet-client/Makefile
6

Exactly, you must only bump PORTREVISION when the resulting package changes, in this case, it did not.