Add nscreate/nsdelete and nsattach/nsdetach to nvmecontrol
and support in nvme driver for same.
Details
Details
- Reviewers
imp - Commits
- rS333275: Add NVMe Namespace Management support to nvmecontrol(8).
Tested nscreate/nsattach partition, mount, write/read and
nsdetach/nsdelete on HGST 4500 and Samsung PM963 nvme drives supporting
namespace and attachement command sets. Ensure existing nvme drives not
supporting namespace (Intel 750) continue to work as expected.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
First round of suggestions. I haven't had a chance to delve deeply into these changes, so this is just what jumped out.
| sbin/nvmecontrol/identify.c | ||
|---|---|---|
| 69 ↗ | (On Diff #30189) | I've pushed this upstream. |
| sys/dev/nvme/nvme_ctrlr.c | ||
| 1006–1017 ↗ | (On Diff #30189) | Rather than a special case in sniffing the passthrough commands, why not register async namespace notifications and use those instead and get rid of all this special case code. |
| sys/dev/nvme/nvme_sim.c | ||
| 185 ↗ | (On Diff #30189) | Why wasn't it causing problems before? I don't understand. |
| 262 ↗ | (On Diff #30189) | I've upstreamed something better here. |
| 266 ↗ | (On Diff #30189) | This change is gratuitous. |
| 278 ↗ | (On Diff #30189) | This change is gratuitous. |
| 280 ↗ | (On Diff #30189) | Is this where what causes the uninitialized namespace issue? |