Page MenuHomeFreeBSD

devel/codesearch-py: Python library for accessing Chromium CodeSearch
ClosedPublic

Authored by cpm on Jun 24 2017, 9:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 12:02 PM
Unknown Object (File)
Jan 1 2024, 3:46 PM
Unknown Object (File)
Jan 1 2024, 3:42 PM
Unknown Object (File)
Jan 1 2024, 3:42 PM
Unknown Object (File)
Jan 1 2024, 3:42 PM
Unknown Object (File)
Jan 1 2024, 3:42 PM
Unknown Object (File)
Dec 29 2023, 10:15 AM
Unknown Object (File)
Dec 22 2023, 11:15 PM
Subscribers
None

Details

Summary
devel/codesearch-py: Python library for accessing Chromium CodeSearch

The codesearch Python library provides an interface for talking to the
Chromium CodeSearch backend.

The primary entry point into the library is the codesearch class. Various
message classes you are likely to encounter are defined in messages.py

In addition, the library also includes facilities for maintaining an
ephemeral or persistent cache in order to minimize generated network
traffic.

WWW: https://github.com/chromium/codesearch-py

Reviewed_by: koobs
Differential_Revision:	D11336
Test Plan
  • portlint -AC output looks fine.
  • poudriere testport builds fine on 10.3/i386, 10.3/amd64, 11.0/i386, 11.0/amd64, 12.0/i386 and 12.0/amd64.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cpm edited the summary of this revision. (Show Details)
cpm edited the test plan for this revision. (Show Details)

Looks OK.

Note:

Current code says PORTNAME (codesearch, 404 in PyPI) does NOT equal DISTNAME (codesearch-py) which is disconcerting.

Be careful with naming of python packages that are named from repository names (not PyPI) as many do not match. Check PyPI for their existence first, even under different names. Ideally get upstream to register a PyPI name and use that (independent of the repository name).

I'm tempted to recommend defaulting PORTNAME to DISTNAME (codesearch-py in this case) where the package doesn't exist in PyPI.

This revision is now accepted and ready to land.Jun 24 2017, 9:23 AM
koobs edited the summary of this revision. (Show Details)
cpm edited edge metadata.
  • Use DISTNAME
This revision now requires review to proceed.Jun 26 2017, 1:53 PM
cpm retitled this revision from devel/py-codesearch: Python library for accessing Chromium CodeSearch to devel/codesearch-py: Python library for accessing Chromium CodeSearch.
cpm edited the summary of this revision. (Show Details)
  • Rename to codesearch-py

Looks OK.

Note:

Current code says PORTNAME (codesearch, 404 in PyPI) does NOT equal DISTNAME (codesearch-py) which is disconcerting.

Be careful with naming of python packages that are named from repository names (not PyPI) as many do not match. Check PyPI for their existence first, even under different names. Ideally get upstream to register a PyPI name and use that (independent of the repository name).

I'm tempted to recommend defaulting PORTNAME to DISTNAME (codesearch-py in this case) where the package doesn't exist in PyPI.

I just changed PORTNAME to codesearch-py.

Thanks for reviewing the changes!

Looks good, recommend asking upstream to register codesearch-py PyPI name :)

This revision is now accepted and ready to land.Jun 27 2017, 4:25 AM
This revision was automatically updated to reflect the committed changes.