Page MenuHomeFreeBSD

cad/freecad: update port to 20170527
ClosedPublic

Authored by ultima on Jun 18 2017, 5:58 AM.

Details

Summary
  • Updated to 20170527 (d28bae3)

PR\: 219624
Sumitted by\: Thibault Jouan <tj+freebsd_ports@a13.fr> (maintainer)
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
WARN: Makefile: [0]: possible direct use of command "python" found. use ${PYTHON_CMD} instead.
WARN: Makefile: [0]: possible direct use of command "false" found. use ${FALSE} instead.
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 3 warnings found.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ultima created this revision.Jun 18 2017, 5:58 AM
matthew added inline comments.Jun 18 2017, 1:28 PM
cad/freecad/files/patch-src_Gui_CMakeLists.txt
8 ↗(On Diff #29767)

did you mean to drop the %%LOCALBASE%% token from the patch? This is a very easy mistake to make when using make makepatch

ultima updated this revision to Diff 29780.Jun 18 2017, 2:18 PM

Yeah thanks, I'll have to not work on ports late at from
now on, I make too many mistakes. Should have seen this.

lifanov accepted this revision.Jun 18 2017, 4:31 PM

Drop the spurious change to this file before committing:
cad/freecad/files/patch-src_3rdParty_salomesmesh_src_SMDS_SMDS__Mesh.cpp
It changed just in the timestamp.

You can just do "svn revert <file>".

Otherwise, this looks fine now.

This revision is now accepted and ready to land.Jun 18 2017, 4:31 PM
This revision was automatically updated to reflect the committed changes.