ghostscript.mk: Enable depending on Ghostscript in the test phase
ClosedPublic
Actions

Authored by tobik on Jun 9 2017, 3:59 PM.

Details

Reviewers

lme
mat

Group Reviewers

O5: Ports Framework
portmgr

Commits

rP451376: Enable depending on Ghostscript in the test phase

Summary

Enable depending on Ghostscript in the test phase

Approved by:	??? (mentor)
Differential Revision:	https://reviews.freebsd.org/D?????

This will be required by an upcoming update to graphics/netpbm.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tobik created this revision.Jun 9 2017, 3:59 PM

Owners added a reviewer: O5: Ports Framework.Jun 9 2017, 3:59 PM

Herald added a reviewer: portmgr. · View Herald TranscriptJun 9 2017, 3:59 PM

Harbormaster completed remote builds in B9755: Diff 29381.Jun 9 2017, 3:59 PM

mat added inline comments.Jun 9 2017, 4:43 PM

Mk/Uses/ghostscript.mk
62–67 ↗	(On Diff #29381)	That part is, I think, wrong.

Don't set _GS_TEST_DEP when no run, build, and test dependency was specified.

Also fix some typos s/dependancy/dependency/

Harbormaster completed remote builds in B9761: Diff 29392.Jun 9 2017, 7:12 PM

Looks ok, I'd like another portmgr to review this, maybe an exp-run is required.

tobik mentioned this in D11157: graphics/netpbm: Update to 10.80.00.Jun 12 2017, 1:46 PM

Closed by commit rP451376: Enable depending on Ghostscript in the test phase (authored by tobik). · Explain WhyOct 6 2017, 11:13 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Packages

head/

Mk/

Uses/

ghostscript.mk

22 lines

O5: Ports Framework

Diff 33744

View Options

head/Mk/Uses/ghostscript.mk

Mk/Uses/ghostscript.mk: Enable depending on Ghostscript in the test phaseClosedPublicActions