Add an Author Entity for myself (ultima)
ClosedPublic
Actions

Authored by ultima on Jun 8 2017, 4:03 PM.

Details

Reviewers

lifanov
matthew

Commits

rD50335: Add an Author Entity for myself (ultima)

Summary

Add an Author Entity for myself (ultima)
Updated the List of Developers and Contributors
Added a News Item
Added a PGP Key

Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/D11093

Diff Detail

Repository

rD FreeBSD doc repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ultima created this revision.Jun 8 2017, 4:03 PM

Harbormaster completed remote builds in B9737: Diff 29334.Jun 8 2017, 4:03 PM

ultima edited the summary of this revision. (Show Details)Jun 8 2017, 4:05 PM

Ah! phabricator does make this much easier!

Can you separate out the whitespace changes and commit them separately please?

share/xml/authors.ent
369 ↗	(On Diff #29334)	You've got some whitespace changes creeping in. That's OK, as it looks like those could do with fixing, but the usual procedure for Docs is to commit whitespace changes separately from other content changes.
2315 ↗	(On Diff #29334)	Another whitespace change here.

This revision now requires changes to proceed.Jun 8 2017, 4:22 PM

You don't need "Submitted by:" if you are the author of the change :)
Commit just the new entity and then you can commit the whitespace change separately.

Removing the whitespace changes, I am also going to add the rest of the doc* commits to this diff.